Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Link underlines #423

Open
ppvg opened this issue Nov 29, 2023 · 0 comments
Open

Link underlines #423

ppvg opened this issue Nov 29, 2023 · 0 comments
Labels
a11y Accessibility fixes and improvements Button Component 'Button' Core set From the base set of components Link Component 'Link'
Milestone
Fase 2 Manon

Comments

@ppvg
Copy link
Member

ppvg commented Nov 29, 2023

From independent accessibility report, SC 1.4.1:

Het volgende is geen fout binnen een component, maar wel binnen de aangeleverde instructies: Op verschillende pagina's staan links in de lopende tekst. Op pagina components/button.html gaat het bijvoorbeeld om de links "Beschikbare types" en "Beschikbare button types". Dat dit links zijn, wordt nu enkel overgebracht doordat ze een andere kleur hebben. Dit is niet voor iedereen goed zichtbaar. Het advies is om links in een lopende tekst altijd te onderstrepen. Eventueel mag het contrast tussen de linktekst en de omliggende tekst ook verhoogd worden tot minstens 3,0:1.

The documentation theme (soft) is missing underlines on links.
@ppvg ppvg added the a11y Accessibility fixes and improvements label Nov 29, 2023
@HeleenSG HeleenSG added the Link Component 'Link' label Sep 19, 2024
@reinschaap reinschaap added the Button Component 'Button' label Sep 26, 2024
@Davidemeer Davidemeer added the Core set From the base set of components label Sep 30, 2024
@Davidemeer Davidemeer modified the milestones: Fase 1 Manon, Fase 2 Manon Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
a11y Accessibility fixes and improvements Button Component 'Button' Core set From the base set of components Link Component 'Link'
Projects
None yet
Milestone
Fase 2 Manon
Development

No branches or pull requests
4 participants
@ppvg @HeleenSG @Davidemeer @reinschaap