Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return type for TypedClient.getBucketVersioning() still incorrect? #1303

Open
fflorent opened this issue Jun 5, 2024 · 0 comments
Open

Return type for TypedClient.getBucketVersioning() still incorrect? #1303

fflorent opened this issue Jun 5, 2024 · 0 comments

Comments

@fflorent
Copy link
Contributor

fflorent commented Jun 5, 2024 •
edited
Loading

Follow-up of #1296, see comment #1296 (comment)

The method still may return an empty string when the versioning is disabled on the bucket (that's because the returned <VersioningConfiguration> xml element is empty in such a case).

Otherwise the returned value could be null or undefined, but that may be a breaking change.

I may submit a PR to bring the change if it would be welcome.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@fflorent