Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Glitched into exit portal #2

Open
Fixer-007 opened this issue Dec 21, 2017 · 1 comment
Open

Glitched into exit portal #2

Fixer-007 opened this issue Dec 21, 2017 · 1 comment

Comments

@Fixer-007
Copy link

When you spawn a portal and walk into it in 0.5.0-git and 0.4.17 stable you will spawn immersed with your feet into bottom obsidian block of exit portal, this adds confusion and led to my quick death by falling in the void.

@Fixer-007 Fixer-007 changed the title Portal spawn teleport bug Glitched into exit portal Dec 21, 2017
@Treer
Copy link
Collaborator

Treer commented Nov 13, 2022

This can be fixed now.

Minetest API has an emerge_area() function which not only initiates emerge in a specified area but can provide a callback after that area is fully emerged (you wait until calls_remaining == 0).

It might not have been available when this mod was first written, as the mod tries to use voxel_manip reads to force areas to emerge and it just doesn't work properly. The portal code is full of terrible hacks to try to deal with inability to test [unemerged/unloaded] destinations, and with emerge happening after the portal is created which erases it (the nether mod currently has loops and back-off timers and restores portals after they get overwritten etc).

Falling through the exit portal is one of the bugs that comes from this mess.

One day I want to fix this, because the portal code will get much simpler and many bugs will vanish, but don't foresee time to work on it in the near future so I'm noting this as a directional hint for others in case I don't get back to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants