This repository has been archived by the owner on Jul 24, 2019. It is now read-only.
Added arrow key nav option and some basic docs #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
November 2, 2015 12:31
Pass false on init to disable navigation by arrow keys
| ----------- | ||
| | Name | Effect | Type | Default | | ||
| |------------------|-----------------------------------------|---------|---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------| | ||
| | arrow_navigation | Disables arrow key navigation on table. | Boolean | ```false``` | |
There was a problem hiding this comment.
It's a bit confusing in this way:
arrow_navigation == falsemeans that arrow navigation is enabledarrow_navigation == truemeans that arrow navigation is disabled
Maybe naming it enable_arrow_navigation, making it default to true and inverting all the conditions is clearer
There was a problem hiding this comment.
True. Doesn't look like this will get merged anyways. This project seems dead.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can use the new option to disable arrow key navigation on the table. It causes problems when trying to edit a long string and you try to arrow to the end.