Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropout not used correctly in machine_translation example #46

Open
aalmah opened this issue Sep 29, 2015 · 2 comments
Open

Dropout not used correctly in machine_translation example #46

aalmah opened this issue Sep 29, 2015 · 2 comments

Comments

@aalmah
Copy link

aalmah commented Sep 29, 2015

In this example, dropout is effectively ignored because:

@dwf
Copy link
Contributor

dwf commented Nov 12, 2015

@orhanf thoughts on this?

@orhanf
Copy link
Contributor

orhanf commented Nov 12, 2015

The first item should definitely be fixed, but for the second one, there are some differences between implementations. What we usually monitor is the bleu score or log-prob of the validation set or a subset of the training set. And for both, we use models without any regularization. So, I think, the first item should be fixed, the second can be optional.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants