Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Access to imgscalr options #29

Open
vvvvalvalval opened this issue Feb 17, 2016 · 9 comments
Open

Access to imgscalr options #29

vvvvalvalval opened this issue Feb 17, 2016 · 9 comments

Comments

@vvvvalvalval
Copy link

I've been using imagez to scale down JPEG images but I was dissatisfied with the output quality.

Turns out that you can improve it significantly by using the ULTRA_QUALITY method of imgscalr.

would be interesting to make those options accessible.

@mikera
Copy link
Owner

mikera commented Feb 18, 2016

Sounds like a good idea. Perhaps ULTRA_QUALITY should even be the default?

@vvvvalvalval
Copy link
Author

@mikera I agree, I cannot see any reason not to use it by default (except performance requirements).

@vvvvalvalval
Copy link
Author

@mikera On second thought, having dived a little bit in the documentation, I believe the best course of action is to leave AUTOMATIC by default (which by definition is meant to let the library try and be smart about the algorithm to be used), while exposing tuning options to the user and providing her a link to the documentation.

@rcanepa
Copy link

rcanepa commented Mar 29, 2016

Hi. I am facing the same issue. I can't get a good quality output after scaling (resizing) down an image. @vvvvalvalval, how did you solve the problem?

@vvvvalvalval
Copy link
Author

@rcanepa I ended up going down to ImgScalr via Java interop. Shoud be fairly easy for you to do by looking at the source code of imagez.

@rcanepa
Copy link

rcanepa commented Mar 30, 2016

@vvvvalvalval, excellent. I'll do that too.

@mikera
Copy link
Owner

mikera commented Mar 30, 2016

Happy to have a PR that exposes the options to Clojure (as an additional options map)

@mikera mikera changed the title give access to imgscalr options Access to imgscalr options Mar 2, 2018
@brianium
Copy link

brianium commented May 6, 2018

@mikera just started using this library - it's fantastic. I have a need for this too, are you still open to PRs?

@mikera
Copy link
Owner

mikera commented May 7, 2018

Glad you like it! PRs very welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants