Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Future HA Needs Version Number #5

Open
CoveCompound opened this issue Mar 20, 2021 · 10 comments
Open

Future HA Needs Version Number #5

CoveCompound opened this issue Mar 20, 2021 · 10 comments

Comments

@CoveCompound
Copy link

I just installed your dewpoint calculator and get the attached message "No 'version' key in the manifest file for custom integration 'dewpoint'. This will not be allowed in a future version of Home Assistant. Please report this to the maintainer of 'dewpoint'"

Screenshot 2021-03-20 163940

@Kevinm94
Copy link

Kevinm94 commented Apr 8, 2021

I just started getting the same message. Any way to fix this?

`Logger: homeassistant.loader
Source: loader.py:786
First occurred: 6:44:05 PM (1 occurrences)
Last logged: 6:44:05 PM

No 'version' key in the manifest file for custom integration 'dewpoint'. As of Home Assistant 2021.6, this integration will no longer be loaded. Please report this to the maintainer of 'dewpoint' `

@tomlut
Copy link

tomlut commented Apr 16, 2021

You can add a version number to the manifest file (2nd last line here):

{
  "domain": "dewpoint",
  "name": "DewPoint Sensor Calculator",
  "documentation": "https://github.com/miguelangel-nubla/home-assistant-dewpoint",
  "dependencies": [],
  "codeowners": ["@miguelangel-nubla"],
  "requirements": ["psychrolib==2.1.0"],
  "version": "0.0.0"
}

The file is located here config\custom_components\dewpoint\manifest.json

Note the coma after requirements too.

@tomlut
Copy link

tomlut commented Apr 16, 2021

I've created a pull request to fix this but the repository may be abandoned.

@ehn
Copy link

ehn commented Jun 7, 2021

Given that @miguelangel-nubla seems to be MIA and this integration is now broken on the current HA, I forked the repository and made the minimal change.

@aeble
Copy link

aeble commented Jun 8, 2021

Given that @miguelangel-nubla seems to be MIA and this integration is now broken on the current HA, I forked the repository and made the minimal change.

Wouldn't it make sense to use your repository for HACS etc. then, @ehn ? I mean, if @miguelangel-nubla really has abandoned the project, it would certainly be needed to be removed from HACS and the documentation should be changed to point to your fork, shouldn't it?

@ehn
Copy link

ehn commented Jun 8, 2021

Sure, if people want to use it, I'll update the docs etc accordingly.

@ehn
Copy link

ehn commented Jun 14, 2021

Updated the documentation, manifest etc to reflect the new location. Bumped the version in the manifest from 0.0.0 to 0.0.1. After a while, the update showed up in HACS, though it seems to be using the commit numbers as version identifiers rather than what's in the manifest file:

Update pending

Dew Point Calculator

Installed version: 9a1784f

Available version: ba89011

Remember that you need to restart Home Assistant before changes to integrations (custom_components) are applied.```

@ehn
Copy link

ehn commented Jun 14, 2021

Created a version on GitHub. Now it looks a bit nicer in HACS.

@ehn
Copy link

ehn commented Jun 14, 2021

And just to be clear so as not to step on anyone's toes, I'm not trying to co-opt this project. Very happy if @miguelangel-nubla wants to keep maintaining it. Just created the fork for my own use and made it public so that not every user has to do the same thing to keep using the component.

@taugusti
Copy link

your effort is much appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants