Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: wrap file/folder paths in package.json files in double quotes #3205

Merged
merged 3 commits into from
Jun 12, 2024

Conversation

musale
Copy link
Contributor

@musale musale commented Jun 10, 2024

Closes #3197

PR Type

  • Other

Description of the changes

This is to ensure that the paths are found in Windows and the commands run as expected.

PR checklist

  • Project builds (yarn build) and changes have been tested in at least two supported browsers (Edge + non-Chromium based browser)
  • All public APIs (classes, methods, etc) have been documented following the jsdoc syntax
  • Stories have been added and existing stories have been tested
  • Added appropriate documentation. Docs PR:
  • License header has been added to all new source files (yarn setLicense)
  • Contains NO breaking changes

Other information

This is to ensure that the paths are found in Windows and the commands run as expected

Signed-off-by: Musale Martin <[email protected]>
@musale musale requested a review from a team as a code owner June 10, 2024 08:55
Copy link
Contributor

Thank you for creating a Pull Request @musale.

This is a checklist for the PR reviewer(s) to complete before approving and merging this PR:

  • I have verified a documentation PR has been linked and is approved (or not applicable)
  • I have ran this PR locally and have tested the fix/feature
  • I have verified that stories have been added to storybook (or not applicable)
  • I have tested existing stories in storybook to verify no regression has occured
  • I have tested the solution in at least two browsers (Edge + 1 non-Chromium based browser)

Copy link

📖 The updated storybook is available here

1 similar comment
Copy link

📖 The updated storybook is available here

Copy link

📖 The updated storybook is available here

Copy link

📖 The updated storybook is available here

Copy link

sonarcloud bot commented Jun 10, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@musale musale merged commit 2be7fae into main Jun 12, 2024
11 checks passed
@musale musale deleted the chore/escape-fixes-for-windev branch June 12, 2024 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[BUG] npm run lint fails in Windows
2 participants