-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: tab behavior on person while closing person-card #3193
Conversation
Thank you for creating a Pull Request @Mnickii. This is a checklist for the PR reviewer(s) to complete before approving and merging this PR:
|
📖 The updated storybook is available here |
2 similar comments
📖 The updated storybook is available here |
📖 The updated storybook is available here |
@vagpt this is ready for review |
📖 The updated storybook is available here |
This issue is still repro on the URL below. Please find the attachment for the reference. issue.repro.after.activating.the.profile.button.mp4 |
📖 The updated storybook is available here |
📖 The updated storybook is available here |
📖 The updated storybook is available here |
@vagpt @Raisul123 this is ready for testing |
packages/mgt-components/src/components/mgt-person-card/mgt-person-card.ts
Outdated
Show resolved
Hide resolved
📖 The updated storybook is available here |
packages/mgt-components/src/components/mgt-person/mgt-person.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Musale Martin <[email protected]>
📖 The updated storybook is available here |
|
📖 The updated storybook is available here |
Ping @vagpt and @Raisul123 this is ready for review. |
📖 The updated storybook is available here |
Quality Gate passedIssues Measures |
This issue is now working fine on the URL below, hence we are good to close the bug related to this PR. URL: https://mgt.dev/next/pr/3193/?path=/story/components-mgt-person-html--person-vertical |
Closes #3130
PR Type
Bugfix
Description of the changes
PR checklist
yarn build
) and changes have been tested in at least two supported browsers (Edge + non-Chromium based browser)yarn setLicense
)Other information