Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: tab behavior on person while closing person-card #3193

Merged
merged 9 commits into from
Jun 10, 2024
Merged

Conversation

Mnickii
Copy link
Collaborator

@Mnickii Mnickii commented May 29, 2024

Closes #3130

PR Type

Bugfix

Description of the changes

PR checklist

  • Project builds (yarn build) and changes have been tested in at least two supported browsers (Edge + non-Chromium based browser)
  • All public APIs (classes, methods, etc) have been documented following the jsdoc syntax
  • Stories have been added and existing stories have been tested
  • Added appropriate documentation. Docs PR:
  • License header has been added to all new source files (yarn setLicense)
  • Contains NO breaking changes

Other information

Copy link
Contributor

Thank you for creating a Pull Request @Mnickii.

This is a checklist for the PR reviewer(s) to complete before approving and merging this PR:

  • I have verified a documentation PR has been linked and is approved (or not applicable)
  • I have ran this PR locally and have tested the fix/feature
  • I have verified that stories have been added to storybook (or not applicable)
  • I have tested existing stories in storybook to verify no regression has occured
  • I have tested the solution in at least two browsers (Edge + 1 non-Chromium based browser)

Copy link

📖 The updated storybook is available here

2 similar comments
Copy link

📖 The updated storybook is available here

Copy link

📖 The updated storybook is available here

@Mnickii
Copy link
Collaborator Author

Mnickii commented May 29, 2024

@vagpt this is ready for review

Copy link

📖 The updated storybook is available here

@vagpt
Copy link
Collaborator

vagpt commented May 30, 2024

This issue is still repro on the URL below. Please find the attachment for the reference.

issue.repro.after.activating.the.profile.button.mp4

Copy link

📖 The updated storybook is available here

Copy link

github-actions bot commented Jun 4, 2024

📖 The updated storybook is available here

Copy link

github-actions bot commented Jun 4, 2024

📖 The updated storybook is available here

@Mnickii
Copy link
Collaborator Author

Mnickii commented Jun 4, 2024

@vagpt @Raisul123 this is ready for testing

Copy link

github-actions bot commented Jun 5, 2024

📖 The updated storybook is available here

@Mnickii Mnickii requested a review from musale June 5, 2024 13:37
Copy link

github-actions bot commented Jun 5, 2024

📖 The updated storybook is available here

Copy link

github-actions bot commented Jun 5, 2024

Code Coverage

Package Line Rate Branch Rate Complexity Health
mgt-components.src.components 86% 75% 0
mgt-components.src.components.mgt-contact 68% 83% 0
mgt-components.src.components.mgt-file 62% 100% 0
mgt-components.src.components.mgt-file-list 46% 100% 0
mgt-components.src.components.mgt-file-list.mgt-file-upload 49% 86% 0
mgt-components.src.components.mgt-get 22% 100% 0
mgt-components.src.components.mgt-messages 68% 100% 0
mgt-components.src.components.mgt-organization 47% 100% 0
mgt-components.src.components.mgt-person 82% 100% 0
mgt-components.src.components.mgt-person-card 77% 49% 0
mgt-components.src.components.mgt-picker 80% 100% 0
mgt-components.src.components.mgt-profile 40% 100% 0
mgt-components.src.components.mgt-tasks-base 87% 100% 0
mgt-components.src.components.mgt-theme-toggle 100% 100% 0
mgt-components.src.components.mgt-todo 79% 100% 0
mgt-components.src.components.sub-components.mgt-flyout 78% 53% 0
mgt-components.src.components.sub-components.mgt-spinner 100% 100% 0
mgt-components.src.graph 38% 78% 0
mgt-components.src.styles 92% 80% 0
mgt-components.src.utils 79% 27% 0
mgt-element.dist.es6.components.src.components 72% 73% 0
mgt-element.dist.es6.mock.src.mock 90% 72% 0
mgt-element.dist.es6.providers.src.providers 85% 73% 0
mgt-element.dist.es6.src 91% 80% 0
mgt-element.dist.es6.utils.src.utils 68% 71% 0
mgt-element.src 93% 40% 0
mgt-element.src.components 78% 100% 0
mgt-element.src.mock 81% 56% 0
mgt-element.src.providers 84% 100% 0
mgt-element.src.utils 72% 91% 0
Summary 67% (14570 / 21595) 74% (520 / 702) 0

Copy link

github-actions bot commented Jun 7, 2024

📖 The updated storybook is available here

@musale
Copy link
Contributor

musale commented Jun 10, 2024

Ping @vagpt and @Raisul123 this is ready for review.

Copy link

📖 The updated storybook is available here

Copy link

sonarcloud bot commented Jun 10, 2024

@vagpt
Copy link
Collaborator

vagpt commented Jun 10, 2024

This issue is now working fine on the URL below, hence we are good to close the bug related to this PR.

URL: https://mgt.dev/next/pr/3193/?path=/story/components-mgt-person-html--person-vertical

Attachment:
https://github.com/microsoftgraph/microsoft-graph-toolkit/assets/95913748/0a4fc90b-bbcb-4378-8a49-6c9a88342626

@musale musale merged commit 6a93c6e into main Jun 10, 2024
11 checks passed
@musale musale deleted the fix/bug-3130 branch June 10, 2024 16:42
@Mnickii Mnickii added this to the 4.2.3 milestone Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
3 participants