-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(a11y): set the title and aria-label for the screen sizing buttons #3188
Conversation
Thank you for creating a Pull Request @musale. This is a checklist for the PR reviewer(s) to complete before approving and merging this PR:
|
📖 The updated storybook is available here |
@vagpt review this for a11y |
📖 The updated storybook is available here |
📖 The updated storybook is available here |
This issue is working fine on the URL below, hence we are good to close issue related to this PR.. URL: https://mgt.dev/next/pr/3188/?path=/docs/overview--docs#storybook-preview-wrapper Attachment: Now.SR.is.not.announcing.the.irrelevant.info.mp4Also, @Mnickii @gavinbarron, Since issue #3075 was marked external to Storybook and we have added external bug id as well in the bug so do we need to remove the external tagging? |
📖 The updated storybook is available here |
|
Closes #3075
PR Type
Description of the changes
Rewrites the title attribute value for the screen sizing buttons
Sets the aria-label attribute value to the title value of the sizing buttons
PR checklist
yarn build
) and changes have been tested in at least two supported browsers (Edge + non-Chromium based browser)yarn setLicense
)Other information