Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(a11y): set the title and aria-label for the screen sizing buttons #3188

Merged
merged 3 commits into from
May 29, 2024

Conversation

musale
Copy link
Contributor

@musale musale commented May 24, 2024

Closes #3075

PR Type

  • Bugfix

Description of the changes

Rewrites the title attribute value for the screen sizing buttons
Sets the aria-label attribute value to the title value of the sizing buttons

PR checklist

  • Project builds (yarn build) and changes have been tested in at least two supported browsers (Edge + non-Chromium based browser)
  • All public APIs (classes, methods, etc) have been documented following the jsdoc syntax
  • Stories have been added and existing stories have been tested
  • Added appropriate documentation. Docs PR:
  • License header has been added to all new source files (yarn setLicense)
  • Contains NO breaking changes

Other information

@musale musale requested a review from a team as a code owner May 24, 2024 09:36
Copy link
Contributor

Thank you for creating a Pull Request @musale.

This is a checklist for the PR reviewer(s) to complete before approving and merging this PR:

  • I have verified a documentation PR has been linked and is approved (or not applicable)
  • I have ran this PR locally and have tested the fix/feature
  • I have verified that stories have been added to storybook (or not applicable)
  • I have tested existing stories in storybook to verify no regression has occured
  • I have tested the solution in at least two browsers (Edge + 1 non-Chromium based browser)

Copy link

📖 The updated storybook is available here

@musale
Copy link
Contributor Author

musale commented May 27, 2024

@vagpt review this for a11y

Copy link

📖 The updated storybook is available here

@musale musale changed the title fix: set the title and aria-label for the screen sizing buttons fix(a11y): set the title and aria-label for the screen sizing buttons May 28, 2024
Copy link

📖 The updated storybook is available here

@vagpt
Copy link
Collaborator

vagpt commented May 29, 2024

This issue is working fine on the URL below, hence we are good to close issue related to this PR..

URL: https://mgt.dev/next/pr/3188/?path=/docs/overview--docs#storybook-preview-wrapper

Attachment:

Now.SR.is.not.announcing.the.irrelevant.info.mp4

Also, @Mnickii @gavinbarron,

Since issue #3075 was marked external to Storybook and we have added external bug id as well in the bug so do we need to remove the external tagging?

Copy link

📖 The updated storybook is available here

Copy link

Code Coverage

Package Line Rate Branch Rate Complexity Health
mgt-components.src.components 86% 75% 0
mgt-components.src.components.mgt-contact 68% 83% 0
mgt-components.src.components.mgt-file 62% 100% 0
mgt-components.src.components.mgt-file-list 46% 100% 0
mgt-components.src.components.mgt-file-list.mgt-file-upload 49% 86% 0
mgt-components.src.components.mgt-get 22% 100% 0
mgt-components.src.components.mgt-messages 68% 100% 0
mgt-components.src.components.mgt-organization 47% 100% 0
mgt-components.src.components.mgt-person 82% 100% 0
mgt-components.src.components.mgt-person-card 77% 49% 0
mgt-components.src.components.mgt-picker 80% 100% 0
mgt-components.src.components.mgt-profile 40% 100% 0
mgt-components.src.components.mgt-tasks-base 87% 100% 0
mgt-components.src.components.mgt-theme-toggle 100% 100% 0
mgt-components.src.components.mgt-todo 79% 100% 0
mgt-components.src.components.sub-components.mgt-flyout 78% 53% 0
mgt-components.src.components.sub-components.mgt-spinner 100% 100% 0
mgt-components.src.graph 38% 78% 0
mgt-components.src.styles 92% 80% 0
mgt-components.src.utils 79% 27% 0
mgt-element.dist.es6.components.src.components 72% 73% 0
mgt-element.dist.es6.mock.src.mock 91% 73% 0
mgt-element.dist.es6.providers.src.providers 85% 76% 0
mgt-element.dist.es6.src 91% 80% 0
mgt-element.dist.es6.utils.src.utils 68% 71% 0
mgt-element.src 93% 40% 0
mgt-element.src.components 78% 100% 0
mgt-element.src.mock 81% 56% 0
mgt-element.src.providers 84% 100% 0
mgt-element.src.utils 72% 91% 0
Summary 67% (14551 / 21559) 74% (519 / 699) 0

@musale musale merged commit 6395096 into main May 29, 2024
10 checks passed
@musale musale deleted the fix/screensize-btn-a11y branch May 29, 2024 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
3 participants