Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fixing person string unions for react stories #2978

Merged
merged 2 commits into from
Jan 29, 2024

Conversation

sebastienlevert
Copy link
Contributor

Closes #2977

PR Type

  • Bugfix

Description of the changes

Adding the right string vs. enums for our React stories!

PR checklist

  • Project builds (yarn build) and changes have been tested in at least two supported browsers (Edge + non-Chromium based browser)
  • All public APIs (classes, methods, etc) have been documented following the jsdoc syntax
  • Stories have been added and existing stories have been tested
  • Added appropriate documentation. Docs PR:
  • License header has been added to all new source files (yarn setLicense)
  • Contains NO breaking changes

Other information

Copy link

Code Coverage

Package Line Rate Branch Rate Complexity Health
mgt-components.src.components 85% 67% 0
mgt-components.src.components.mgt-contact 63% 100% 0
mgt-components.src.components.mgt-file 62% 100% 0
mgt-components.src.components.mgt-file-list 46% 100% 0
mgt-components.src.components.mgt-file-list.mgt-file-upload 49% 86% 0
mgt-components.src.components.mgt-get 22% 100% 0
mgt-components.src.components.mgt-messages 68% 100% 0
mgt-components.src.components.mgt-organization 47% 100% 0
mgt-components.src.components.mgt-person 78% 65% 0
mgt-components.src.components.mgt-person-card 50% 65% 0
mgt-components.src.components.mgt-picker 80% 100% 0
mgt-components.src.components.mgt-profile 40% 100% 0
mgt-components.src.components.mgt-tasks-base 87% 100% 0
mgt-components.src.components.mgt-theme-toggle 100% 100% 0
mgt-components.src.components.mgt-todo 79% 100% 0
mgt-components.src.components.sub-components.mgt-flyout 72% 53% 0
mgt-components.src.components.sub-components.mgt-spinner 100% 100% 0
mgt-components.src.graph 38% 86% 0
mgt-components.src.styles 92% 80% 0
mgt-components.src.utils 78% 11% 0
mgt-element.dist.es6.components.src.components 72% 73% 0
mgt-element.dist.es6.mock.src.mock 91% 73% 0
mgt-element.dist.es6.providers.src.providers 83% 69% 0
mgt-element.dist.es6.src 90% 100% 0
mgt-element.dist.es6.utils.src.utils 63% 72% 0
mgt-element.src 93% 40% 0
mgt-element.src.components 78% 100% 0
mgt-element.src.mock 81% 56% 0
mgt-element.src.providers 83% 91% 0
mgt-element.src.utils 71% 90% 0
Summary 64% (13729 / 21438) 64% (375 / 585) 0

Copy link

📖 The updated storybook is available here

@sebastienlevert sebastienlevert marked this pull request as ready for review January 29, 2024 17:35
@sebastienlevert sebastienlevert requested a review from a team as a code owner January 29, 2024 17:35
Copy link

📖 The updated storybook is available here

@gavinbarron gavinbarron merged commit 92a6b5e into main Jan 29, 2024
8 checks passed
@gavinbarron gavinbarron deleted the fix/react-snippets branch January 29, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[BUG] React snippets have mixed enums vs. string unions
2 participants