You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug npm run lint fails with the following error in Windows:
PS > npm run lint
> [email protected] lint
> npm run lint:eslint && npm run lint:styles
> [email protected] lint:eslint
> eslint -c .eslintrc.js --quiet 'packages/*/src/**/*.ts'
Oops! Something went wrong! :(
ESLint: 8.57.0
No files matching the pattern "'packages/*/src/**/*.ts'" were found.
Please check for typing mistakes in the pattern.
To Reproduce
Check out the repo on a Windows machine
Run npm run lint and observe the error
Expected behavior
Linting works on a Windows machine.
Environment (please complete the following information):
OS: Windows 11
Additional context cross-env npm package resolves this issue.
The text was updated successfully, but these errors were encountered:
Hello @zengin, thank you for raising this issue. By default, we encourage development on mgt to use yarn. From this #2718, we leverage features of yarn like zero-install which improve collaboration by ensuring we have consistent dependencies, and you can easily switch between branches in development. Additional development level dependencies are discouraged. More information on development can be found here https://github.com/microsoftgraph/microsoft-graph-toolkit/wiki#setup-the-development-environment.
Lastly, I ran the project on Windows and ran yarn run lint. There was an error which I believe is because we are not escaping the \"path\to\files\" around file paths but using the single 'path\to\file' that works on Linux. I have put up a PR to fix this here #3205
Describe the bug
npm run lint
fails with the following error in Windows:To Reproduce
npm run lint
and observe the errorExpected behavior
Linting works on a Windows machine.
Environment (please complete the following information):
Additional context
cross-env
npm package resolves this issue.The text was updated successfully, but these errors were encountered: