Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terminal executable does not check path if a dir of the same name exists at the cwd #83772

Closed
Tyriar opened this issue Oct 31, 2019 · 6 comments · Fixed by #158666
Closed

Terminal executable does not check path if a dir of the same name exists at the cwd #83772

Tyriar opened this issue Oct 31, 2019 · 6 comments · Fixed by #158666
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug help wanted Issues identified as good community contribution opportunities insiders-released Patch has been released in VS Code Insiders terminal Integrated terminal issues verified Verification succeeded

Comments

@Tyriar
Copy link
Member

Tyriar commented Oct 31, 2019

Context dotnet/vscode-csharp#3372 (comment)

Repro:

  1. Have dotnet in $PATH
  2. Open a folder
  3. Create a dotnet folder inside the root
  4. Set the terminal shell as dotnet
@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug help wanted Issues identified as good community contribution opportunities terminal Integrated terminal issues labels Oct 31, 2019
@Tyriar Tyriar added this to the November 2019 milestone Oct 31, 2019
@Tyriar Tyriar self-assigned this Oct 31, 2019
@Tyriar Tyriar modified the milestones: November 2019, Backlog Dec 2, 2019
@Tyriar Tyriar modified the milestones: Backlog, September 2022 Sep 15, 2022
@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Sep 15, 2022
@joyceerhl
Copy link
Contributor

@Tyriar what are some verification steps for this?

@joyceerhl joyceerhl added the verification-steps-needed Steps to verify are needed for verification label Oct 3, 2022
@Tyriar
Copy link
Member Author

Tyriar commented Oct 3, 2022

@joyceerhl the steps above in #83772 (comment), just open a terminal at the end and make sure it works

@Tyriar Tyriar removed the verification-steps-needed Steps to verify are needed for verification label Oct 3, 2022
@joyceerhl joyceerhl added the verified Verification succeeded label Oct 3, 2022
@joyceerhl
Copy link
Contributor

I'm not totally sure what step 4 is about, I created a terminal and ran the dotnet command
image

@Tyriar
Copy link
Member Author

Tyriar commented Oct 7, 2022

@joyceerhl oh ok, it's using old terminology. You need to create and launch this profile:

  "terminal.integrated.profiles.windows": {
    "dotnet": {
      "path": "dotnet"
    }
  }

@joyceerhl
Copy link
Contributor

When creating and launching that profile with dotnet in the path I see a terminal get created, then it immediately closes and I get this error notification:

image

@Tyriar
Copy link
Member Author

Tyriar commented Oct 7, 2022

Oh ok 🤷, but it still fixed the bug as it's picking it up off the path, not the workspace folder

@github-actions github-actions bot locked and limited conversation to collaborators Oct 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug help wanted Issues identified as good community contribution opportunities insiders-released Patch has been released in VS Code Insiders terminal Integrated terminal issues verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants