Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create-comment: monaco editor should disable line-number manipulating API for extensions? #229521

Open
ulugbekna opened this issue Sep 24, 2024 · 0 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug comments Comments Provider/Widget/Panel issues
Milestone

Comments

@ulugbekna
Copy link
Contributor

ulugbekna commented Sep 24, 2024

description

Editor used by create-comment view allows extensions to manipulate line number kind (relative vs absolute) making left padding none.

repro

  1. have vim extension
  2. set setting vim.smartRelativeLine to true (setting to configure line number (relative vs absolute) automatically depending on vim mode)
  3. checkout a PR and select lines and use gesture to write a comment on changes
  4. press i (a vim way of making editor non-readonly) - 🐛 line number appears too close to text
CleanShot.2024-09-24.at.11.18.14.mp4

same problem microsoft/vscode-python#24167

Version: 1.94.0-insider
Commit: f35c382
Date: 2024-09-24T05:04:12.797Z
Electron: 30.5.1
ElectronBuildId: 10262041
Chromium: 124.0.6367.243
Node.js: 20.16.0
V8: 12.4.254.20-electron.0
OS: Darwin arm64 23.6.0

@alexr00 alexr00 added the bug Issue identified by VS Code Team member as probable bug label Sep 24, 2024
@alexr00 alexr00 transferred this issue from microsoft/vscode-pull-request-github Sep 24, 2024
@alexr00 alexr00 added the comments Comments Provider/Widget/Panel issues label Sep 24, 2024
@alexr00 alexr00 added this to the October 2024 milestone Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug comments Comments Provider/Widget/Panel issues
Projects
None yet
Development

No branches or pull requests

2 participants