Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syntax highlight of Ruby is broken on percent notations #137713

Closed
takaram opened this issue Nov 23, 2021 · 1 comment
Closed

Syntax highlight of Ruby is broken on percent notations #137713

takaram opened this issue Nov 23, 2021 · 1 comment
Assignees
Labels
grammar Syntax highlighting grammar upstream-issue-linked This is an upstream issue that has been reported upstream

Comments

@takaram
Copy link

takaram commented Nov 23, 2021

Does this issue occur when all extensions are disabled?: Yes

  • VS Code Version: 1.62.3, 1.63.0-insider
  • OS Version: Windows_NT x64 10.0.19042

Steps to Reproduce:

  1. Create .rb file
  2. Input code like below
puts %(() parentheses)
puts %<{} braces>
puts %Q{[] brackets}
puts %r[[^a-z]]
puts %(
  def foo()
    puts 123
  rescue
    nil
  end
)
puts %x(echo '() parentheses')

Expected:
The literal is recognized as strings (or regexp) until the closing bracket.
Specification of Ruby percent notations: http://www.chrisrolle.com/en/blog/ruby-percentage-notations

Actual:
image

@alexr00
Copy link
Member

alexr00 commented Nov 24, 2021

Moved to the repository that we get our ruby syntax highlighting grammar from: textmate/ruby.tmbundle#140

@alexr00 alexr00 closed this as completed Nov 24, 2021
@alexr00 alexr00 added grammar Syntax highlighting grammar upstream Issue identified as 'upstream' component related (exists outside of VS Code) upstream-issue-linked This is an upstream issue that has been reported upstream and removed upstream Issue identified as 'upstream' component related (exists outside of VS Code) labels Nov 24, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Jan 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
grammar Syntax highlighting grammar upstream-issue-linked This is an upstream issue that has been reported upstream
Projects
None yet
Development

No branches or pull requests

3 participants