Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[libiconv] Fix arm64-ios build #42111

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[libiconv] Fix arm64-ios build #42111

wants to merge 2 commits into from

Conversation

cosmin42
Copy link

Fixes the arm64-ios build.

  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

Original issue:
#36182

Original fix: https://git.savannah.gnu.org/gitweb/?p=gnulib.git;a=commitdiff;h=2d1edb0bd8035200d09ba4bd6d0161f37e0ee1f4

@cosmin42
Copy link
Author

@microsoft-github-policy-service agree

@Mengna-Li Mengna-Li added the category:port-bug The issue is with a library, which is something the port should already support label Nov 12, 2024
Mengna-Li
Mengna-Li requested changes Nov 12, 2024
View reviewed changes
ports/libiconv/portfile.cmake
@@ -19,6 +19,7 @@ vcpkg_extract_source_archive(SOURCE_PATH
0003-Add-export.patch
0004-ModuleFileName.patch
clang-fortify.patch # ported from https://git.savannah.gnu.org/cgit/gnulib.git/commit/?id=522aea1093a598246346b3e1c426505c344fe19a
0005-iOS-missing-symbol-fix.patch
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please upgrade the port-version.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mengna-Li Mengna-Li Mengna-Li requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@Mengna-Li Mengna-Li

Labels
category:port-bug The issue is with a library, which is something the port should already support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cosmin42 @Mengna-Li @yonutix