Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[vulkan-sdk-*] Update to 1.3.296 #41586

Merged
merged 2 commits into from
Oct 19, 2024
Merged

[vulkan-sdk-*] Update to 1.3.296 #41586

merged 2 commits into from
Oct 19, 2024

Conversation

siukosev
Copy link
Contributor

@siukosev siukosev commented Oct 16, 2024 •
edited
Loading

  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@siukosev
Copy link
Contributor Author

@microsoft-github-policy-service agree

@Cheney-W Cheney-W added the category:port-update The issue is with a library, which is requesting update new revision label Oct 16, 2024
@siukosev siukosev force-pushed the vulkan-sdk-1.3.296 branch 2 times, most recently from a07d366 to 868e4f1 Compare October 16, 2024 20:06
@siukosev siukosev marked this pull request as ready for review October 16, 2024 20:10
@siukosev
Copy link
Contributor Author

siukosev commented Oct 16, 2024 •
edited
Loading

vulkan-loader arm64 build still failing for some reason. Worked on my PC. I will investigate it later.

@LilyWangLL LilyWangLL added the requires:all-feature-testing vcpkg install port[all features supported by that port] needs to be demonstrated to function label Oct 17, 2024
@LilyWangLL
Copy link
Contributor

All features passed with following triplets:

x86-windows
x64-windows
x64-windows-static

@LilyWangLL LilyWangLL removed the requires:all-feature-testing vcpkg install port[all features supported by that port] needs to be demonstrated to function label Oct 18, 2024
LilyWangLL
LilyWangLL previously approved these changes Oct 18, 2024
View reviewed changes
@LilyWangLL LilyWangLL added the info:reviewed Pull Request changes follow basic guidelines label Oct 18, 2024
@BillyONeal
Copy link
Member

I replaced the checked in patch with upstream's actual commits in vulkan-loader so that it's clear we're applying something upstream agrees with. Thanks for the update!

@BillyONeal BillyONeal enabled auto-merge (squash) October 18, 2024 22:35
@BillyONeal BillyONeal merged commit d567b66 into microsoft:master Oct 19, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BillyONeal BillyONeal BillyONeal approved these changes

@LilyWangLL LilyWangLL LilyWangLL left review comments

Assignees

@LilyWangLL LilyWangLL

Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@siukosev @LilyWangLL @BillyONeal @Cheney-W