Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vcpkg] Rewrite custom fmt formatters to a supported way #32784

Closed
xvitaly opened this issue Jul 27, 2023 · 2 comments
Closed

[vcpkg] Rewrite custom fmt formatters to a supported way #32784

xvitaly opened this issue Jul 27, 2023 · 2 comments
Assignees
Labels
category:vcpkg-feature The issue is a new capability of the tool that doesn’t already exist and we haven’t committed Stale

Comments

@xvitaly
Copy link

xvitaly commented Jul 27, 2023

Describe the bug
Currently, vcpkg uses an unsupported way of creating custom formatters by changing the internal inline namespace, which causes serious problems when building vcpkg against different versions of fmtlib.

The problem is the use of the inline namespace fmt::vX in include/vcpkg/base/fwd/format.h. All other sources are okay and can be built with fmt 8.0 - 10.

I asked upstream and they suggested a good documented way: https://fmt.dev/latest/api.html#formatting-user-defined-types

Environment

  • OS: ANY
  • Compiler: ANY

To Reproduce
Steps to reproduce the behavior:

  1. Try to build against different fmtlib version.

Expected behavior
It should be built successfully.

Actual behaviour
Build failure due to hardcoded inline namespace ABI version.

@Adela0814 Adela0814 added the category:vcpkg-feature The issue is a new capability of the tool that doesn’t already exist and we haven’t committed label Jul 27, 2023
Copy link

This is an automated message. Per our repo policy, stale issues get closed if there has been no activity in the past 180 days. The issue will be automatically closed in 14 days. If you wish to keep this issue open, please add a new comment.

@github-actions github-actions bot added the Stale label Jan 24, 2024
@LilyWangLL LilyWangLL self-assigned this Feb 20, 2024
@github-actions github-actions bot removed the Stale label Mar 23, 2024
Copy link

This is an automated message. Per our repo policy, stale issues get closed if there has been no activity in the past 180 days. The issue will be automatically closed in 14 days. If you wish to keep this issue open, please add a new comment.

@github-actions github-actions bot added the Stale label Sep 20, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:vcpkg-feature The issue is a new capability of the tool that doesn’t already exist and we haven’t committed Stale
Projects
None yet
Development

No branches or pull requests

3 participants