Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[flann] 'pop_t':Undefined type #32448

Closed
Bzz2745 opened this issue Jul 8, 2023 · 2 comments · Fixed by #32468
Closed

[flann] 'pop_t':Undefined type #32448

Bzz2745 opened this issue Jul 8, 2023 · 2 comments · Fixed by #32468
Assignees
Labels
category:port-bug The issue is with a library, which is something the port should already support depends:upstream-changes Waiting on a change to the upstream project

Comments

@Bzz2745
Copy link

Bzz2745 commented Jul 8, 2023

Is your feature request related to a problem? Please describe.

In file flann/algorithm/dist.h:
image
image
It is obvious that the 'pop_t' type is defined under the GNUC platform, but is still used on other platforms that do not define the 'pop_t' type (see line 522 in Figure 2).

Proposed solution

I just want it can be use.

Describe alternatives you've considered

I don't know how the type 'pop_t' differs between platforms, but if not, the definition of 'pop_t' should be moved to the top of the line that distinguishes between different platforms (move to the next line of 479 lines) or change the sizeof (pop_t) of line 522 below to sizeof (unsigned long long).

Additional context

No response

@Bzz2745 Bzz2745 added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label Jul 8, 2023
@StarGate-One
Copy link
Contributor

StarGate-One commented Jul 8, 2023

@jimwang118 jimwang118 added category:port-bug The issue is with a library, which is something the port should already support depends:upstream-changes Waiting on a change to the upstream project and removed category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist labels Jul 10, 2023
@jimwang118
Copy link
Contributor

This problem was raised in the upstream issue, but it seems that it has not been fixed for a long time. Looking at the reply in the upstream issue, someone mentioned the definition of pop_t outside the platform judgment to fix this problem. I will make a patch like this to fix it .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support depends:upstream-changes Waiting on a change to the upstream project
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants