http-client-java, unknown map to binary data #4738
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microsoft-github-policy-service
bot
added
the
emitter:client:java
|
No changes needing a change description found. |
|
You can try these changes here
|
...com/microsoft/typespec/http/client/generator/core/model/clientmodel/ClientModelProperty.java
Outdated
Show resolved
Hide resolved
...r-core/src/main/java/com/microsoft/typespec/http/client/generator/core/mapper/AnyMapper.java
Show resolved
Hide resolved
weidongxu-microsoft
requested review from
srnagar,
haolingdong-msft and
XiaofeiCao
as code owners
XiaofeiCao
reviewed
Oct 15, 2024
...n/java/com/type/property/additionalproperties/models/ExtendsUnknownAdditionalProperties.java
Show resolved
Hide resolved
XiaofeiCao
approved these changes
Oct 15, 2024
packages/http-client-java/generator/http-client-generator-test/Generate.ps1
Show resolved
Hide resolved
haolingdong-msft
approved these changes
Oct 17, 2024
weidongxu-microsoft
removed this pull request from the merge queue due to a manual request
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 18, 2024
both tcgc and resource-manager got a patch bump, not sure what changed though. preparing a patch release, before #4738 that patch mostly for bumping the npm dependencies, as these patch may intended to fix some problem (and we don't want them get mixed with the bigger PR). we do not expect sdk code change upon this patch.
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #4669
Added
use-object-for-unknownto both swagger/typespec flag. Default isfalse, meaning useBinaryData.(we had 2 or 3 GA lib get affected, and may need to use this flag)
Pending issue Azure/autorest.java#2964