Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Astro website migrate all components to astro components #4710

Merged
merged 43 commits into from
Oct 18, 2024

Conversation

timotheeguerin
Copy link
Member

@timotheeguerin timotheeguerin commented Oct 12, 2024

progress for #2564

  • Get rid of fluent ui jsx apart from the playground as it cannot be SSr with astro
  • Use pure astro components for everything which force them to be fully rendered on the UI

@azure-sdk
Copy link
Collaborator

azure-sdk commented Oct 12, 2024

No changes needing a change description found.

@azure-sdk
Copy link
Collaborator

You can try these changes here

🛝 Playground 🌐 Website 📚 Next docs

@timotheeguerin timotheeguerin mentioned this pull request Oct 12, 2024
2 tasks
@timotheeguerin timotheeguerin marked this pull request as ready for review October 14, 2024 17:16
@chrisradek
Copy link
Member

Posting some oddities I'm seeing with these changes:

smaller example doesn't fill 'screen' space
image

No footer in the new version
Left side is this PR, right side is current docusaurus version. Not sure how important it is to have the footer, though might be nice to still have the privacy/trademarks/terms of use links there.
image

Lack of padding on community page
image

model props have same color as decorators
This is pretty nit picky/subjective, but I liked that the old version of the docs used a different color for model properties than for decorators - made it very easy to see what the decorators applied to. Not sure how much control we have here.
image

@timotheeguerin timotheeguerin added this pull request to the merge queue Oct 18, 2024
Merged via the queue into microsoft:main with commit 524fa9e Oct 18, 2024
22 checks passed
@timotheeguerin timotheeguerin deleted the astro-migration-step-2 branch October 18, 2024 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants