New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add xml support to openapi3 #4214

Open

skywing918 wants to merge 145 commits into microsoft:main from skywing918:xmlClient

Member

skywing918 commented Aug 20, 2024 •

edited

Loading

add test cases based on Examples
add xml in OpenAPI3Schema type
update schema-emitter logic for support xml object


          initial xml schema

324231d

skywing918 requested review from bterlson, markcowl, allenjzhang and timotheeguerin as code owners

August 20, 2024 09:16

skywing918 changed the title ~~initial xml schema~~ Add xml support to openapi3

Kyle Zhang and others added 11 commits

August 20, 2024 17:23


          update

fb8d16a


          Merge branch 'main' into xmlClient

fd480f1


          update all logic for xml object

430f1c2


          Merge branch 'main' into xmlClient

0b1d92e


          update

76d78bb


          Merge branch 'xmlClient' of https://github.com/skywing918/typespec in…

979080f

…to xmlClient


          update cases

afcc306


          Merge branch 'microsoft:main' into xmlClient

7f7a8c0


          Merge branch 'main' into xmlClient

6bc86c6


          update Scenario 1.3

c55136d


          Merge branch 'main' into xmlClient

d2e97f3

skywing918 marked this pull request as draft

August 28, 2024 07:06


          Merge branch 'main' into xmlClient

ccbfaee

timotheeguerin reviewed

View reviewed changes

.chronus/changes/simple-xml-support-2024-7-23-14-23-13.md Outdated Show resolved Hide resolved

timotheeguerin reviewed

View reviewed changes

packages/compiler/src/core/index.ts Outdated Show resolved Hide resolved

timotheeguerin reviewed

View reviewed changes

packages/openapi3/package.json Outdated Show resolved Hide resolved

timotheeguerin reviewed

View reviewed changes

packages/openapi3/test/xml-models.test.ts Outdated Show resolved Hide resolved

timotheeguerin reviewed

View reviewed changes

packages/openapi3/test/xml-models.test.ts Outdated Show resolved Hide resolved

wanlwanl reviewed

View reviewed changes

packages/openapi3/src/schema-emitter.ts Outdated Show resolved Hide resolved

skywing918 and others added 5 commits

August 30, 2024 15:11


          Merge branch 'main' into xmlClient

06f9fdc


          move func from compiler to openapi3

4b99815


          update for comments

56ccc79


          revert

4079c23


          update

2b27393

timotheeguerin reviewed

View reviewed changes

packages/openapi3/src/xml-module.ts Outdated Show resolved Hide resolved

timotheeguerin reviewed

View reviewed changes

packages/openapi3/src/xml-module.ts Outdated Show resolved Hide resolved

timotheeguerin reviewed

View reviewed changes

packages/openapi3/src/xml-module.ts Outdated Show resolved Hide resolved

timotheeguerin reviewed

View reviewed changes

packages/openapi3/src/xml-module.ts Outdated Show resolved Hide resolved

skywing918 and others added 13 commits

October 17, 2024 10:03


          Update packages/openapi3/src/lib.ts

f361191

Co-authored-by: Timothee Guerin <[email protected]>


          Update packages/openapi3/src/lib.ts

2bb718d

Co-authored-by: Timothee Guerin <[email protected]>


          Update packages/openapi3/src/xml-module.ts

a21eeac

Co-authored-by: Timothee Guerin <[email protected]>


          Update packages/openapi3/src/xml-module.ts

c57a917

Co-authored-by: Timothee Guerin <[email protected]>


          update


          Merge branch 'main' into xmlClient

70c9226


          update case

3e31d9a


          change the type of ref be OpenAPI3Schema

e702666


          warning and change the type to be type: string if attribute is object

622e660


          Merge branch 'main' into xmlClient

b4f5eb2


          update

0e7d771


          update message

13b7be2


          Merge branch 'main' into xmlClient

8cb031e

Member

timotheeguerin commented Oct 17, 2024

/azp run typespec - pr tools

azure-pipelines bot commented Oct 17, 2024

Azure Pipelines successfully started running 1 pipeline(s).

timotheeguerin reviewed

View reviewed changes

packages/openapi3/src/xml-module.ts Show resolved Hide resolved

timotheeguerin reviewed

View reviewed changes

packages/openapi3/src/lib.ts Outdated Show resolved Hide resolved

timotheeguerin reviewed

View reviewed changes

packages/openapi3/src/lib.ts Outdated Show resolved Hide resolved

timotheeguerin reviewed

View reviewed changes

Member

timotheeguerin left a comment

Just some message change and a question on a warning but otherwise I think this starts to look good, @chrisradek was also going to take another look to have another set of eyes to double check we implemented it respecting openapi3/typespec specs

timotheeguerin requested a review from chrisradek

October 17, 2024 17:14

skywing918 and others added 6 commits

October 18, 2024 07:44


          Update packages/openapi3/src/lib.ts

b45816b

Co-authored-by: Timothee Guerin <[email protected]>


          Update packages/openapi3/src/lib.ts

7e55f1f

Co-authored-by: Timothee Guerin <[email protected]>


          Merge branch 'main' into xmlClient

c477090


          update case

66249f1


          Merge branch 'main' into xmlClient

f678268


          Merge branch 'main' into xmlClient

71a5b13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

timotheeguerin timotheeguerin left review comments

wanlwanl wanlwanl left review comments

bterlson Awaiting requested review from bterlson bterlson is a code owner

markcowl Awaiting requested review from markcowl markcowl is a code owner

allenjzhang Awaiting requested review from allenjzhang allenjzhang is a code owner

chrisradek Awaiting requested review from chrisradek

At least 1 approving review is required to merge this pull request.

Labels

None yet