Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SpaceNet6 datamodule #2367

Merged
merged 10 commits into from
Oct 27, 2024
Merged

Add SpaceNet6 datamodule #2367

merged 10 commits into from
Oct 27, 2024

Conversation

nilsleh
Copy link
Collaborator

@nilsleh nilsleh commented Oct 24, 2024

This PR adds a DataModule for SpaceNet6. And makes the following changes:

  • Introduce SpaceNetBaseDataModule
  • Add dummy test data for SpaceNet1, it exists in the actual dataset, but not in the dummy data
  • Add dummy data for SpaceNet6
  • Resctructure tests/data/spacenet/ to generate test data for each version

Other Notes:

  • The "test" data in SpaceNet comes without labels, so in the datamodules, I have configured them to be "predict" data.
  • One could also restructure the data.py scripts, because there are shared functions that can be utilized across versions.
  • it would be nice to have geospatial train/val/test splits generated from the train data, and not random splits

@nilsleh nilsleh marked this pull request as draft October 24, 2024 10:29
@github-actions github-actions bot added documentation Improvements or additions to documentation testing Continuous integration testing datamodules PyTorch Lightning datamodules labels Oct 24, 2024
@nilsleh nilsleh marked this pull request as ready for review October 24, 2024 16:44
Copy link
Collaborator

@adamjstewart adamjstewart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Knowing full well how different each SpaceNet version is, I won't try to ask you to combine the data.py to avoid code duplication. Hopefully someday we can have data modules for all versions.

tests/datasets/test_spacenet.py Show resolved Hide resolved
@adamjstewart adamjstewart enabled auto-merge (squash) October 27, 2024 09:06
@adamjstewart adamjstewart merged commit c746cac into microsoft:main Oct 27, 2024
19 checks passed
@nilsleh nilsleh deleted the space6dm branch October 27, 2024 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
datamodules PyTorch Lightning datamodules documentation Improvements or additions to documentation testing Continuous integration testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants