Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The weight of CJK characters in the title of the active tab is inappropriate #18175

Open
YexuanXiao opened this issue Nov 11, 2024 · 2 comments
Open

The weight of CJK characters in the title of the active tab is inappropriate #18175

YexuanXiao opened this issue Nov 11, 2024 · 2 comments
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal.
Milestone
Terminal v1.24

Comments

@YexuanXiao
Copy link

Windows Terminal version

Source

Windows build number

22621/27744

Other Software

No response

Steps to reproduce

The default font in Simplified Chinese user environments is Microsoft Yahei UI. The current font weight causes the Chinese characters in the titles to be unclear.

Expected Behavior

Image
100% DPI scale, right is the active tab
Image
200% DPI scale, right is the active tab

Actual Behavior

Set FontWeight to Normal, Medium, or Bold (instead of Default or SemiLight).
@YexuanXiao YexuanXiao added Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Nov 11, 2024
@carlos-zamora
Copy link
Member

Thanks for filing! We should:

  • file a bug on XAML
  • workaround this in our own code

@carlos-zamora carlos-zamora added this to the Terminal v1.24 milestone Nov 13, 2024
@carlos-zamora carlos-zamora added Area-User Interface Issues pertaining to the user interface of the Console or Terminal Product-Terminal The new Windows Terminal. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Nov 13, 2024
@carlos-zamora carlos-zamora mentioned this issue Nov 14, 2024
Open
@carlos-zamora
Copy link
Member

Filed upstream on XAML: microsoft/microsoft-ui-xaml#10169

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal.
Projects
None yet
Milestone
Terminal v1.24
Development

No branches or pull requests
2 participants
@carlos-zamora @YexuanXiao