Add supplier/license info for cargo and pip #479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebasgomez238
commented
Jan 12, 2024
| @@ -78,6 +78,7 @@ public abstract class ComponentDetectionBaseWalker | |||
| // Enable SPDX22 and ConanLock detector which is disabled by default. | |||
| cliArgumentBuilder.AddDetectorArg("SPDX22SBOM", "EnableIfDefaultOff"); | |||
| cliArgumentBuilder.AddDetectorArg("ConanLock", "EnableIfDefaultOff"); | |||
| cliArgumentBuilder.AddDetectorArg("RustCli", "EnableIfDefaultOff"); | |||
There was a problem hiding this comment.
RustCli detector is not enabled by default. Must be enabled manually here.
sebasgomez238
commented
Jan 12, 2024
| @@ -29,6 +29,8 @@ protected override IEnumerable<ScannedComponent> FilterScannedComponents(ScanRes | |||
| return result | |||
| .ComponentsFound | |||
| .Where(component => !(component.Component is SpdxComponent)) // We exclude detected SBOMs from packages section and reference them as an ExternalReference | |||
| .GroupBy(component => component.Component.Id) | |||
There was a problem hiding this comment.
Now that both the RustCrateDetector and the RustCli detector are both running we may have duplicates. In this scenario we always want to take the one that came from the RustCli as this one contains Author and Supplier information.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #479 +/- ##
==========================================
+ Coverage 59.82% 59.85% +0.03%
==========================================
Files 268 268
Lines 8249 8256 +7
Branches 972 973 +1
==========================================
+ Hits 4935 4942 +7
Misses 2886 2886
Partials 428 428 ☔ View full report in Codecov by Sentry. |
sfoslund
approved these changes
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires #476 to be merged for it's changes in ServiceCollectionExtensions as well as v4.0.12 of component-detection to be released
Edit: all requirements have been met.