Only download zips if you have file access #10257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I forgot that there were parts of this PR (#10255) that were actually good fixes that I wanted to keep. I realize now that I could've just reopened that PR, but here we are.
We shouldn't let the user download a zip of their projects if they don't have access to the file system, so I added the check to the
Download Zipbutton. I moved thehasFileAccessfunction toBrowserUtilsbecause of this. If there are more places where we might want to check for file access, we now have the function in a more accessible place.The addition of the
inGamecheck toBrowserUtilsis no longer being used, however, there were a couple of scenarios where I almost needed a check like this and I think it's just nice to have in case there are needs for it.Upload target: https://minecraft.makecode.com/app/d06e69d2392ce4bcc73cf7790a8632c0b38adc0a-8bc3309a1d