Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: update web socket tests to properly dispatch ws messages #1683

Merged
merged 1 commit into from
Oct 3, 2024
Merged

test: update web socket tests to properly dispatch ws messages #1683

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions playwright/src/test/java/com/microsoft/playwright/TestRouteWebSocket.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,8 +148,8 @@ public void shouldWorkWithBinaryTypeBlob(String mock, Page page) throws Exceptio
page.evaluate("window.log"));
Future<String> messagePromise = webSocketServer.waitForMessage();
page.evaluate("() => window.ws.send(new Blob([new Uint8Array(['h'.charCodeAt(0), 'i'.charCodeAt(0)])]))");
// Without this the blob message is not sent in pass-through!
assertEquals(1, page.evaluate("window.ws.readyState"));
// Dispatch messages until web socket route is received.
page.waitForCondition(() -> messagePromise.isDone());
assertEquals("hi", messagePromise.get());
}

Expand All @@ -171,8 +171,8 @@ public void shouldWorkWithBinaryTypeArrayBuffer(String mock, Page page) throws E
page.evaluate("window.log"));
Future<String> messagePromise = webSocketServer.waitForMessage();
page.evaluate("() => window.ws.send(new Blob([new Uint8Array(['h'.charCodeAt(0), 'i'.charCodeAt(0)])]))");
// Without this the blob message is not sent in pass-through!
assertEquals(1, page.evaluate("window.ws.readyState"));
// Dispatch messages until web socket route is received.
page.waitForCondition(() -> messagePromise.isDone());
assertEquals("hi", messagePromise.get());
}

Expand Down
Loading