Fix native_batch_norm_legit on cuda | fix(torchlib) #1292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @titaiwangms for helping with the environment! |
justinchuby
added
the
topic: torch_lib
titaiwangms
approved these changes
Mar 8, 2024
Test Results 24 files ±0 24 suites ±0 1h 26m 12s ⏱️ - 6m 2s For more details on these failures, see this check. Results for commit 7836931. ± Comparison against base commit 3b59a74. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjusted output dtypes for the op to match the that in the graph exported with GPU.
In float16, output 4 of
native_batch_norm_legit_functional(new_running_var), when training=True, does not match the gpu output in 4/12 cases, and only in Eager mode. I am marking it as xfail-fixme for the time being because I couldn't see what went wrong.Fixes #1256