Add CoreML ML Program Resize #21370
Merged
Add CoreML ML Program Resize #21370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- refactor existing logic to try and simplify and share between NeuralNetwork and MLProgram checks
- add handling for some new attributes
- antialias and axes
- should have been done when setting the CoreML EP max opset to 21
Handle Resize-11 where scales is empty. Refactor how the the base op builder allows empty input
skottmckay
commented
Jul 17, 2024
Remove redudant test.
edgchen1
reviewed
Jul 17, 2024
onnxruntime/core/providers/coreml/builders/impl/resize_op_builder.cc
Outdated
Show resolved
Hide resolved
onnxruntime/core/providers/coreml/builders/impl/resize_op_builder.cc
Outdated
Show resolved
Hide resolved
onnxruntime/core/providers/coreml/builders/impl/resize_op_builder.cc
Outdated
Show resolved
Hide resolved
onnxruntime/core/providers/coreml/builders/impl/resize_op_builder.cc
Outdated
Show resolved
Hide resolved
Use helper in CoreML EP to check if there are dims with value of zero. Refine check when downsampling with scales
skottmckay
commented
Jul 18, 2024
onnxruntime/core/providers/nnapi/nnapi_builtin/builders/impl/resize_op_builder.cc
Show resolved
Hide resolved
edgchen1
reviewed
Jul 18, 2024
onnxruntime/core/providers/coreml/builders/impl/resize_op_builder.cc
Outdated
Show resolved
Hide resolved
edgchen1
reviewed
Jul 19, 2024
edgchen1
previously approved these changes
Jul 19, 2024
edgchen1
approved these changes
Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add CoreML ML Program Resize
Motivation and Context
Support priority models