Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JS/WegGPU] Initial changes to support wasm64. #21260

Closed
wants to merge 51 commits into from

Conversation

satyajandhyala
Copy link
Contributor

Description

Changes to support wasm64.

Motivation and Context

@satyajandhyala
Copy link
Contributor Author

@dakenf, I have some changes from your PR to enable wasm64. I am running into the following error
Error: no available backend found. ERR: [webgpu] RuntimeError: Aborted(Assertion failed: JSPI not supported by current environment. Perhaps it needs to be enabled via flags?)

Using either of the following commands:
npm test -- model test\data\node\opset8\test_add -x 1 -b=webgpu --chromium-flags=--experimental-wasm-memory64 --chroumim-flags=--enable-experimental-webassembly-jspi
or
npx karma start --browsers ChromeCanaryTest --single-run --force-localhost --bundle-mode=dev --chromium-flags=--enable-features=SharedArrayBuffer --chromium-flags=--experimental-wasm-memory64 --chromium-flags=--headless=new --chromium-flags=--enable-dawn-features=allow_unsafe_apis,use_dxc

@satyajandhyala
Copy link
Contributor Author

@dakenf Is there any compiler option requires. I have commented-out protc target options in onnxruntime-webassembly.cmake

@satyajandhyala satyajandhyala force-pushed the sajandhy/webgpu_support_64_bit_integer branch from 4e5cd1d to 018f1c9 Compare July 5, 2024 06:04
@satyajandhyala
Copy link
Contributor Author

@fs-eire I enabled JSPI in ChromeCanary browser and npx uses ChromeCanary instead of Chrome. Still I am getting the error saying that the environment does not support JSPI. Any idea?

@satyajandhyala satyajandhyala force-pushed the sajandhy/webgpu_support_64_bit_integer branch from 018f1c9 to 3ea20e9 Compare July 10, 2024 06:29
@satyajandhyala satyajandhyala added the ep:WebGPU ort-web webgpu provider label Jul 11, 2024
@satyajandhyala satyajandhyala force-pushed the sajandhy/webgpu_support_64_bit_integer branch from deb72fe to 640c5ce Compare July 13, 2024 00:22
@satyajandhyala
Copy link
Contributor Author

satyajandhyala commented Jul 14, 2024

I have to pass enable-wasm-memorry64 option as follows to overcome the above mentioned error using --js-flags settings
npm test -- model test\data\node\opset8\test_add -x 1 -b=webgpu -e canary --chromium-flags=--experimental-wasm-memory64 --chroumim-flags=--enable-experimental-wasm-memory64 --chromium-flags=--js-flags=--experimental-wasm-memory64

@satyajandhyala satyajandhyala marked this pull request as ready for review July 18, 2024 01:06
@satyajandhyala satyajandhyala changed the title [WIP][JS/WegGPU] Initial changes to support wasm64. [JS/WegGPU] Initial changes to support wasm64. Jul 18, 2024
@satyajandhyala satyajandhyala marked this pull request as ready for review July 30, 2024 16:01
@satyajandhyala satyajandhyala marked this pull request as draft July 30, 2024 16:13
@satyajandhyala satyajandhyala marked this pull request as ready for review July 30, 2024 22:00
@satyajandhyala
Copy link
Contributor Author

/azp run Big Models Linux Android Emulator QNN CI Pipeline Linux CPU CI Pipeline Linux CPU Minimal Build E2E CI Pipeline Linux GPU CI Pipeline Linux OpenVINO CI Pipeline Linux QNN CI Pipeline MacOS CI Pipeline

Copy link

No pipelines are associated with this pull request.

@satyajandhyala satyajandhyala deleted the sajandhy/webgpu_support_64_bit_integer branch August 23, 2024 02:04
@satyajandhyala
Copy link
Contributor Author

satyajandhyala commented Aug 23, 2024

Opened a new PR with changed branch name.
#21836

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ep:WebGPU ort-web webgpu provider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant