Adds ATen fallback for scaled_dot_product_attention #21107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
orttraining/orttraining/python/training/ortmodule/_custom_op_symbolic_registry.py
Fixed
Show fixed
Hide fixed
orttraining/orttraining/python/training/ortmodule/_custom_gradient_registry.py
Fixed
Show fixed
Hide fixed
orttraining/orttraining/python/training/ortmodule/_custom_op_symbolic_registry.py
Fixed
Show fixed
Hide fixed
orttraining/orttraining/python/training/ortmodule/_custom_op_symbolic_registry.py
Fixed
Show fixed
Hide fixed
orttraining/orttraining/python/training/ortmodule/_custom_op_symbolic_registry.py
Fixed
Show fixed
Hide fixed
orttraining/orttraining/python/training/ortmodule/_custom_op_symbolic_registry.py
Fixed
Show fixed
Hide fixed
orttraining/orttraining/python/training/ortmodule/_custom_op_symbolic_registry.py
Fixed
Show fixed
Hide fixed
orttraining/orttraining/python/training/ortmodule/_custom_op_symbolic_registry.py
Fixed
Show fixed
Hide fixed
orttraining/orttraining/python/training/ortmodule/_custom_op_symbolic_registry.py
Fixed
Show fixed
Hide fixed
orttraining/orttraining/test/python/orttraining_test_ortmodule_api.py
Dismissed
Show dismissed
Hide dismissed
pengwa
reviewed
Jul 17, 2024
orttraining/orttraining/python/training/ortmodule/_custom_gradient_registry.py
Show resolved
Hide resolved
pengwa
reviewed
Jul 17, 2024
orttraining/orttraining/python/training/ortmodule/_custom_op_symbolic_registry.py
Show resolved
Hide resolved
pengwa
approved these changes
Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Introduces an ATen fallback for
torch.nn.functional.scaled_dot_product_attention. This operator was introduced in torch 2.0 and, since then, has had many updates including the implementation of memory efficient attention for V100 machines. The current torchscript exporter exports a subgraph for attention which does not provide the same memory savings that PyTorch's memory efficient attention kernel provides. Allowing fallback to PyTorch ATen op for attention helps mitigate memory spike issues for models leveraging memory efficient attention.Motivation and Context
Memory issues arose when integrating ONNX Runtime Training with AML Stable Diffusion.