Update README.md #477
Open
Update README.md #477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edgchen1
reviewed
Oct 14, 2024
| @@ -5,6 +5,8 @@ | |||
| This is a basic Object Detection sample application for [ONNX Runtime](https://github.com/microsoft/onnxruntime) on Android with [Ort-Extensions](https://github.com/microsoft/onnxruntime-extensions) support for pre/post processing. The demo app accomplishes the task of detecting objects from a given image. | |||
|
|
|||
| The model used here is from source: [Yolov8 in extensions](https://github.com/microsoft/onnxruntime-extensions/blob/64f20828ce0291394886e277c23529cd1d11320d/tutorials/yolo_e2e.py#L37) and with pre/post processing support. | |||
| The default output model with onnxruntime-extension tools wouldn't include 'scaled_box_out_next' which is used in this example for displaying class-lable and confidence. One more step is required to get that. | |||
| Please Add a `Debug()` on top of [`onnxruntime-extensions/onnxruntime_extensions/tools/add_pre_post_processing_to_model.py:270`](https://github.com/microsoft/onnxruntime-extensions/blob/981cb049ff956a1c99ab178b36ffc83664a678f2/onnxruntime_extensions/tools/add_pre_post_processing_to_model.py#L270). | |||
There was a problem hiding this comment.
maybe show a diff to make the code change clear? this link points to a comment and the required change is not obvious to me. still good to have a link to the code though.
edgchen1
reviewed
Oct 14, 2024
| @@ -5,6 +5,8 @@ | |||
| This is a basic Object Detection sample application for [ONNX Runtime](https://github.com/microsoft/onnxruntime) on Android with [Ort-Extensions](https://github.com/microsoft/onnxruntime-extensions) support for pre/post processing. The demo app accomplishes the task of detecting objects from a given image. | |||
|
|
|||
| The model used here is from source: [Yolov8 in extensions](https://github.com/microsoft/onnxruntime-extensions/blob/64f20828ce0291394886e277c23529cd1d11320d/tutorials/yolo_e2e.py#L37) and with pre/post processing support. | |||
| The default output model with onnxruntime-extension tools wouldn't include 'scaled_box_out_next' which is used in this example for displaying class-lable and confidence. One more step is required to get that. | |||
There was a problem hiding this comment.
Suggested change
| The default output model with onnxruntime-extension tools wouldn't include 'scaled_box_out_next' which is used in this example for displaying class-lable and confidence. One more step is required to get that. | |
| The default output model with onnxruntime-extension tools doesn't include 'scaled_box_out_next' which is used in this example for displaying class label and confidence. One more step is required to get that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.