-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reuse Large Buffers in MigrateSession #623
Merged
vazois
merged 44 commits into
microsoft:main
from
vazois:vazois/migration-reuse-buffers
Sep 27, 2024
Merged
Reuse Large Buffers in MigrateSession #623
vazois
merged 44 commits into
microsoft:main
from
vazois:vazois/migration-reuse-buffers
Sep 27, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vazois
force-pushed
the
vazois/migration-reuse-buffers
branch
4 times, most recently
from
September 4, 2024 20:26
29aa345
to
146da1a
Compare
vazois
force-pushed
the
vazois/migration-reuse-buffers
branch
3 times, most recently
from
September 10, 2024 02:23
e13374e
to
9d65b87
Compare
vazois
force-pushed
the
vazois/migration-reuse-buffers
branch
3 times, most recently
from
September 12, 2024 00:52
18e9c50
to
d34f522
Compare
vazois
force-pushed
the
vazois/migration-reuse-buffers
branch
3 times, most recently
from
September 18, 2024 17:10
c362324
to
dfc86d7
Compare
badrishc
reviewed
Sep 19, 2024
badrishc
reviewed
Sep 19, 2024
badrishc
requested changes
Sep 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments.
badrishc
reviewed
Sep 19, 2024
badrishc
reviewed
Sep 19, 2024
TedHartMS
requested changes
Sep 19, 2024
vazois
force-pushed
the
vazois/migration-reuse-buffers
branch
5 times, most recently
from
September 20, 2024 18:37
8ce1809
to
eceaa1e
Compare
vazois
force-pushed
the
vazois/migration-reuse-buffers
branch
from
September 26, 2024 22:01
392194d
to
c6953af
Compare
TedHartMS
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to improve memory utilization and reduce fragmentation by reusing large buffers that were allocated across different migrate sessions.
The PR includes the following:
Notes:
garnet/libs/common/Memory/LimitedFixedBufferPool.cs
Lines 55 to 61 in 68a7a85