Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

$export fails on Accept header from HttpClient #3876

Open
LodewijkSioen opened this issue May 27, 2024 · 1 comment
Open

$export fails on Accept header from HttpClient #3876

LodewijkSioen opened this issue May 27, 2024 · 1 comment
Labels
Bug Bug bug bug. Up for grabs The issue require minimal context and is well-suited for new contributors.

Comments

@LodewijkSioen
Copy link

Describe the bug
The dotnet (8) HttpClient insists on adding ; charset=utf-8 to the Accept-header of a request. This causes an error in the $export operation because this line of code checks if the accept header is exactly the same as application/fhir+json. I think this line should be changed to StartsWith.

FHIR Version?
R4

Data provider?
SQL Server

To Reproduce
Steps to reproduce the behavior:

  1. Call the $export endpoint with a dotnet HttpClient
  2. Watch it burn

Expected behavior
It should work

Actual behavior

Operation was unsuccessful because of a client error (BadRequest). OperationOutcome: Overall result: FAILURE (1 errors and 0 warnings)\r\n[ERROR] (no details)(further diagnostics: Value supplied for the \"Accept\" header is not supported.)\r\n.
@LodewijkSioen LodewijkSioen added the Bug Bug bug bug. label May 27, 2024
@LodewijkSioen
Copy link
Author

Sorry, the issue is with the Firely FhirClient, not the dotnet fhirclient. Still, I think the issue is valid.

@EXPEkesheth EXPEkesheth added Review Tag for PM/Dev Review Up for grabs The issue require minimal context and is well-suited for new contributors. and removed Review Tag for PM/Dev Review labels Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Bug bug bug. Up for grabs The issue require minimal context and is well-suited for new contributors.
Projects
None yet
Development

No branches or pull requests

2 participants