Fix partition initialization bug. #10702
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After creating a partition, the toolkit must wait for the partition device to be created (under /dev). However, the naming scheme of partitions is inconsistent, with both `/dev/<name>XX` and `/dev/<name>pXX` being used, depending on the device driver. So, the toolkit checks for both. However, a problem occurs when the device name itself ends in a digit. If the disk device path is say `/dev/loop1`, then `/dev/loop11` is also a valid disk device path. For such disks, the `/dev/<name>pXX` form must be used for partitions. While the toolkit prioritizes `/dev/loop1p1` over `/dev/loop11`, if the `/dev/loop1p1` device doesn't exist yet and `/dev/loop11` is in use, then the toolkit may pick the wrong device path for the partition. This change fixes this by ignoring the `/dev/<name>XX` variant if the disk device path ends in a digit.
dmcilvaney
reviewed
Oct 11, 2024
|
|
||
| // If disk path ends in a digit, then the 'p<x>' style must be used. | ||
| // So, don't check the other style to avoid ambiguities. For example, /dev/loop1 vs. /dev/loop11. | ||
| // The is particularly relevant on Ubuntu, due to snap's use of loopback devices. |
There was a problem hiding this comment.
Suggested change
| // The is particularly relevant on Ubuntu, due to snap's use of loopback devices. | |
| // This is particularly relevant on Ubuntu, due to snap's use of loopback devices. |
dmcilvaney
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After creating a partition, the toolkit must wait for the partition device to be created (under /dev). However, the naming scheme of partitions is inconsistent, with both
/dev/<name>XXand/dev/<name>pXXbeing used, depending on the device driver. So, the toolkit checks for both.However, a problem occurs when the device name itself ends in a digit. If the disk device path is say
/dev/loop1, then/dev/loop11is also a valid disk device path. For such disks, the/dev/<name>pXXform must be used for partitions.While the toolkit prioritizes
/dev/loop1p1over/dev/loop11, if the/dev/loop1p1device doesn't exist yet and/dev/loop11is in use, then the toolkit may pick the wrong device path for the partition.This change fixes this by ignoring the
/dev/<name>XXvariant if the disk device path ends in a digit.Merge Checklist
All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)
*-staticsubpackages, etc.) have had theirReleasetag incremented../cgmanifest.json,./toolkit/scripts/toolchain/cgmanifest.json,.github/workflows/cgmanifest.json)./LICENSES-AND-NOTICES/SPECS/data/licenses.json,./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md,./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)*.signatures.jsonfilessudo make go-tidy-allandsudo make go-test-coveragepassDoes this affect the toolchain?
NO
Test Methodology