Add batching support to sdk #647
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to lay the foundation for the batching feature where we provide convenience functions for users to provide a list of xyz files and then the SDK converts these to QcSchema to be uploaded to the service. The QcSchema are uploaded as individual blobs to the storage account container used for the job. This PR takes advantage of the container URI that is already be used to save the output to.
Tests were defined for the functions that generate QcSchema using pytest and pytest-regressions. End-to-end testing was performed manually by submitting a single job batch to canary for each job type.