-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate cost estimation in azure-quantum-python SDK #646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
warren-jones
changed the title
Deprecate cost estimation in azure-quantum-python SDK
[Draft - Do not merge] Deprecate cost estimation in azure-quantum-python SDK
Oct 17, 2024
warren-jones
changed the title
[Draft - Do not merge] Deprecate cost estimation in azure-quantum-python SDK
Deprecate cost estimation in azure-quantum-python SDK
Oct 22, 2024
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
kikomiss
reviewed
Oct 22, 2024
kikomiss
reviewed
Oct 22, 2024
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
kikomiss
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description from User Story 26613:
Over time we found that cost estimation logic that we provide in azure-quantum Python SDK is significantly inaccurate and does not provide much benefit for users.
To deprecate cost estimation we need:
azure-quantum-python/azure-quantum/azure/quantum/target/target.py
Line 320 in 4e5d05d
Documentation revisions are addressed in PR 1441