Fix JSDoc @import resolution in `--moduleResolution bundler` #60011

andrewbranch · 2024-09-19T21:41:00Z

jakebailey · 2024-09-24T20:55:40Z

typescript-bot · 2024-09-24T20:55:43Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top400`	✅ Started	✅ Results
`user test this`	✅ Started	✅ Results
`run dt`	✅ Started	✅ Results
`perf test this faster`	✅ Started	👀 Results

typescript-bot · 2024-09-24T21:33:10Z

@jakebailey Here are the results of running the user tests with tsc comparing main and refs/pull/60011/merge:

Everything looks good!

typescript-bot · 2024-09-24T21:34:16Z

Hey @jakebailey, the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

typescript-bot · 2024-09-24T21:42:39Z

@jakebailey
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₀	₃₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,340	_62,340	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,378	_50,378	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{193,901k (± 0.97%)}	_{193,905k (± 0.96%)}	_~	_192,691k	_196,319k	_{p=0.748 n=6}
_{Parse Time}	_{1.57s (± 0.48%)}	_{1.57s (± 0.48%)}	_~	_1.56s	_1.58s	_{p=1.000 n=6}
_{Bind Time}	_{0.86s (± 0.95%)}	_{0.86s (± 1.36%)}	_~	_0.85s	_0.88s	_{p=0.498 n=6}
_{Check Time}	_{11.32s (± 0.24%)}	_{11.37s (± 0.33%)}	_~	_11.31s	_11.42s	_{p=0.053 n=6}
_{Emit Time}	_{3.25s (± 0.92%)}	_{3.23s (± 1.85%)}	_~	_3.12s	_3.29s	_{p=0.747 n=6}
_{Total Time}	_{17.00s (± 0.13%)}	_{17.04s (± 0.13%)}	_{+0.03s (+ 0.20%)}	_17.00s	_17.06s	_{p=0.036 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₇	₇	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_947,102	_947,102	_~	_~	_~	_{p=1.000 n=6}
_Types	_410,738	_410,738	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,224,015k (± 0.00%)}	_{1,224,017k (± 0.00%)}	_~	_1,223,933k	_1,224,094k	_{p=0.936 n=6}
_{Parse Time}	_{7.84s (± 0.75%)}	_{7.90s (± 0.56%)}	_~	_7.84s	_7.96s	_{p=0.054 n=6}
_{Bind Time}	_{2.22s (± 0.64%)}	_{2.23s (± 0.54%)}	_~	_2.22s	_2.25s	_{p=0.493 n=6}
_{Check Time}	_{36.35s (± 0.31%)}	_{36.48s (± 0.40%)}	_~	_36.31s	_36.65s	_{p=0.149 n=6}
_{Emit Time}	_{17.89s (± 0.23%)}	_{17.92s (± 0.61%)}	_~	_17.80s	_18.11s	_{p=0.748 n=6}
_{Total Time}	_{64.30s (± 0.16%)}	_{64.52s (± 0.33%)}	_~	_64.27s	_64.78s	_{p=0.093 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,521,651	_2,521,651	_~	_~	_~	_{p=1.000 n=6}
_Types	_936,037	_936,037	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,351,756k (± 0.00%)}	_{2,351,775k (± 0.00%)}	_~	_2,351,704k	_2,351,857k	_{p=0.810 n=6}
_{Parse Time}	_{10.99s (± 0.51%)}	_{11.02s (± 0.36%)}	_~	_10.97s	_11.07s	_{p=0.377 n=6}
_{Bind Time}	_{2.56s (± 0.57%)}	_{2.56s (± 0.59%)}	_~	_2.53s	_2.57s	_{p=0.622 n=6}
_{Check Time}	_{86.58s (± 0.34%)}	_{86.64s (± 0.35%)}	_~	_86.26s	_87.06s	_{p=0.748 n=6}
_{Emit Time}	_{0.32s (± 3.09%)}	_{0.33s (± 2.99%)}	_~	_0.31s	_0.34s	_{p=0.116 n=6}
_{Total Time}	_{100.45s (± 0.26%)}	_{100.55s (± 0.30%)}	_~	_100.10s	_100.94s	_{p=0.810 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,250,056	_1,250,064	_{+8 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_264,970	_264,977	_{+7 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,404,319k (± 0.01%)}	_{2,464,920k (± 5.96%)}	_~	_2,403,762k	_2,764,903k	_{p=0.471 n=6}
_{Parse Time}	_{6.11s (± 0.63%)}	_{6.14s (± 1.35%)}	_~	_6.08s	_6.30s	_{p=0.872 n=6}
_{Bind Time}	_{2.28s (± 0.39%)}	_{2.26s (± 0.53%)}	_{-0.02s (- 0.73%)}	_2.25s	_2.28s	_{p=0.027 n=6}
_{Check Time}	_{41.38s (± 0.56%)}	_{41.18s (± 0.80%)}	_~	_40.68s	_41.69s	_{p=0.173 n=6}
_{Emit Time}	_{3.62s (± 4.28%)}	_{3.58s (± 3.60%)}	_~	_3.46s	_3.83s	_{p=0.419 n=6}
_{Total Time}	_{53.40s (± 0.54%)}	_{53.17s (± 0.70%)}	_~	_52.68s	_53.69s	_{p=0.230 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,250,056	_1,250,064	_{+8 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_264,970	_264,977	_{+7 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,479,946k (± 0.02%)}	_{2,479,337k (± 0.02%)}	_~	_2,478,467k	_2,480,361k	_{p=0.173 n=6}
_{Parse Time}	_{7.86s (± 0.86%)}	_{7.87s (± 0.66%)}	_~	_7.80s	_7.91s	_{p=0.575 n=6}
_{Bind Time}	_{2.53s (± 0.56%)}	_{2.53s (± 0.70%)}	_~	_2.50s	_2.55s	_{p=0.627 n=6}
_{Check Time}	_{51.66s (± 0.61%)}	_{51.70s (± 0.81%)}	_~	_51.07s	_52.16s	_{p=0.689 n=6}
_{Emit Time}	_{4.36s (± 2.06%)}	_{4.41s (± 1.59%)}	_~	_4.32s	_4.53s	_{p=0.170 n=6}
_{Total Time}	_{66.42s (± 0.58%)}	_{66.50s (± 0.72%)}	_~	_65.70s	_66.99s	_{p=0.810 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_260,936	_260,944	_{+8 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_106,385	_106,392	_{+7 (+ 0.01%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{436,562k (± 0.02%)}	_{436,748k (± 0.01%)}	_{+186k (+ 0.04%)}	_436,675k	_436,778k	_{p=0.005 n=6}
_{Parse Time}	_{4.25s (± 0.71%)}	_{4.27s (± 0.78%)}	_~	_4.24s	_4.32s	_{p=0.455 n=6}
_{Bind Time}	_{1.61s (± 0.39%)}	_{1.61s (± 0.39%)}	_~	_1.60s	_1.62s	_{p=1.000 n=6}
_{Check Time}	_{22.47s (± 0.44%)}	_{22.53s (± 0.33%)}	_~	_22.43s	_22.65s	_{p=0.378 n=6}
_{Emit Time}	_{1.85s (± 0.82%)}	_{1.86s (± 1.69%)}	_~	_1.83s	_1.92s	_{p=0.806 n=6}
_{Total Time}	_{30.18s (± 0.43%)}	_{30.28s (± 0.34%)}	_~	_30.14s	_30.42s	_{p=0.471 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₆₈	₆₈	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_225,916	_225,916	_~	_~	_~	_{p=1.000 n=6}
_Types	_94,414	_94,414	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{370,910k (± 0.03%)}	_{370,923k (± 0.02%)}	_~	_370,809k	_371,053k	_{p=0.936 n=6}
_{Parse Time}	_{3.44s (± 0.73%)}	_{3.46s (± 0.70%)}	_~	_3.43s	_3.49s	_{p=0.466 n=6}
_{Bind Time}	_{1.93s (± 1.13%)}	_{1.92s (± 0.78%)}	_~	_1.89s	_1.93s	_{p=0.256 n=6}
_{Check Time}	_{19.52s (± 0.09%)}	_{19.57s (± 0.59%)}	_~	_19.40s	_19.67s	_{p=0.374 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{24.89s (± 0.14%)}	_{24.94s (± 0.50%)}	_~	_24.77s	_25.06s	_{p=0.422 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₁	₁	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_3,099,752	_3,099,752	_~	_~	_~	_{p=1.000 n=6}
_Types	_1,068,967	_1,068,967	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{3,196,765k (± 0.00%)}	_{3,196,792k (± 0.00%)}	_~	_3,196,736k	_3,196,871k	_{p=0.575 n=6}
_{Parse Time}	_{17.21s (± 0.45%)}	_{17.17s (± 0.24%)}	_~	_17.11s	_17.22s	_{p=0.375 n=6}
_{Bind Time}	_{5.31s (± 0.39%)}	_{5.37s (± 1.90%)}	_~	_5.30s	_5.55s	_{p=0.572 n=6}
_{Check Time}	_{99.80s (± 0.45%)}	_{99.56s (± 0.37%)}	_~	_99.17s	_100.07s	_{p=0.296 n=6}
_{Emit Time}	_{27.43s (± 0.38%)}	_{28.21s (± 7.66%)}	_~	_27.22s	_32.62s	_{p=0.521 n=6}
_{Total Time}	_{149.75s (± 0.37%)}	_{150.31s (± 1.30%)}	_~	_149.24s	_154.28s	_{p=0.936 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_278,920	_278,920	_~	_~	_~	_{p=1.000 n=6}
_Types	_113,837	_113,837	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{428,303k (± 0.01%)}	_{428,287k (± 0.01%)}	_~	_428,259k	_428,345k	_{p=0.810 n=6}
_{Parse Time}	_{3.29s (± 0.25%)}	_{3.30s (± 0.67%)}	_~	_3.28s	_3.33s	_{p=1.000 n=6}
_{Bind Time}	_{1.44s (± 0.62%)}	_1.43s	_{-0.01s (- 0.69%)}	_~	_~	_{p=0.028 n=6}
_{Check Time}	_{14.97s (± 0.29%)}	_{14.94s (± 0.34%)}	_~	_14.85s	_14.99s	_{p=0.520 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{19.71s (± 0.23%)}	_{19.68s (± 0.30%)}	_~	_19.56s	_19.72s	_{p=0.742 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_540,027	_540,027	_~	_~	_~	_{p=1.000 n=6}
_Types	_181,292	_181,292	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{483,579k (± 0.02%)}	_{483,564k (± 0.01%)}	_~	_483,519k	_483,633k	_{p=1.000 n=6}
_{Parse Time}	_{4.02s (± 0.62%)}	_{4.02s (± 0.24%)}	_~	_4.01s	_4.03s	_{p=0.805 n=6}
_{Bind Time}	_{1.43s (± 0.38%)}	_{1.44s (± 0.72%)}	_~	_1.42s	_1.45s	_{p=0.663 n=6}
_{Check Time}	_{22.91s (± 0.35%)}	_{22.90s (± 0.32%)}	_~	_22.80s	_23.02s	_{p=0.872 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{28.36s (± 0.27%)}	_{28.35s (± 0.24%)}	_~	_28.27s	_28.47s	_{p=0.467 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

typescript-bot · 2024-09-24T22:34:56Z

@jakebailey Here are the results of running the top 400 repos with tsc comparing main and refs/pull/60011/merge:

Everything looks good!

andrewbranch · 2024-09-24T23:10:28Z

I think this can go in after the beta cut if needed, but either way, @sandersn feel free to merge for me upon approval.

sandersn

I'd like to know whether this will make us start resolving @import in TS files.

sandersn · 2024-09-25T20:42:30Z

src/compiler/checker.ts

@@ -4617,12 +4617,10 @@ export function createTypeChecker(host: TypeCheckerHost): TypeChecker {
            ? location
            : (isModuleDeclaration(location) ? location : location.parent && isModuleDeclaration(location.parent) && location.parent.name === location ? location.parent : undefined)?.name ||
                (isLiteralImportTypeNode(location) ? location : undefined)?.argument.literal ||
-                (isInJSFile(location) && isJSDocImportTag(location) ? location.moduleSpecifier : undefined) ||


Does it matter that we aren't checking isInJsFile any more? Would we resolve an @import inside a ts file now?

Confirmed by changing the test to .ts instead. I'll add that as importTag22.ts and merge the PR.

Fix JSDoc @import resolution in --moduleResolution bundler

c2597d0

typescript-bot assigned andrewbranch Sep 19, 2024

typescript-bot added Author: Team For Milestone Bug PRs that fix a bug with a specific milestone labels Sep 19, 2024

andrewbranch requested a review from sandersn September 19, 2024 21:42

sandersn requested changes Sep 25, 2024

View reviewed changes

add negative test for .ts files

72ad4ef

sandersn approved these changes Sep 25, 2024

View reviewed changes

sandersn merged commit 8496039 into microsoft:main Sep 25, 2024
32 checks passed

andrewbranch deleted the bug/60007 branch October 14, 2024 15:07

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix JSDoc @import resolution in `--moduleResolution bundler` #60011

Fix JSDoc @import resolution in `--moduleResolution bundler` #60011

andrewbranch commented Sep 19, 2024

jakebailey commented Sep 24, 2024

typescript-bot commented Sep 24, 2024 •

edited

Loading

typescript-bot commented Sep 24, 2024

typescript-bot commented Sep 24, 2024

typescript-bot commented Sep 24, 2024

tsc

typescript-bot commented Sep 24, 2024

andrewbranch commented Sep 24, 2024

sandersn left a comment

sandersn Sep 25, 2024

sandersn Sep 25, 2024

Fix JSDoc @import resolution in --moduleResolution bundler #60011

Fix JSDoc @import resolution in --moduleResolution bundler #60011

Conversation

andrewbranch commented Sep 19, 2024

jakebailey commented Sep 24, 2024

typescript-bot commented Sep 24, 2024 • edited Loading

typescript-bot commented Sep 24, 2024

typescript-bot commented Sep 24, 2024

typescript-bot commented Sep 24, 2024

tsc

typescript-bot commented Sep 24, 2024

andrewbranch commented Sep 24, 2024

sandersn left a comment

Choose a reason for hiding this comment

sandersn Sep 25, 2024

Choose a reason for hiding this comment

sandersn Sep 25, 2024

Choose a reason for hiding this comment

Fix JSDoc @import resolution in `--moduleResolution bundler` #60011

Fix JSDoc @import resolution in `--moduleResolution bundler` #60011

typescript-bot commented Sep 24, 2024 •

edited

Loading