Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ServiceClient(string connectionstring) with OAuth and LoginPromt = Auto does not have CancellationToken #331

Open
ebesirik opened this issue Nov 3, 2022 · 3 comments
Labels
Investigating We are looking into this issue at this time.

Comments

@ebesirik
Copy link

ebesirik commented Nov 3, 2022

ServiceClient(string connectionstring) with OAuth and LoginPromt = Auto does not have CancellationToken
And is waits for System Browser to complete indefinately so There should be either a wait duration setting or a cancellationtoken parameter (optional maybe)

@MattB-msft
Copy link
Member

In the configuration based constructor we provide a setting called "MSALRequestTimeoutOverride" the default value for this is 30 seconds.

Are you seeing the browser invoke exceed this time?

@ebesirik
Copy link
Author

ebesirik commented Nov 4, 2022

In my scenario, if the user accidentally closes the sign-in system browser, it waits for ever for a request to localhost.
And I can not use config based construct (afaik) because I only have connection string.

@ebesirik ebesirik closed this as completed Nov 4, 2022
@ebesirik ebesirik reopened this Nov 4, 2022
@MattB-msft MattB-msft added the Investigating We are looking into this issue at this time. label Nov 6, 2022
@MattB-msft
Copy link
Member

Ok, Thanks @ebesirik ,
That is defiantly not the behavior want there,
We will look into this and see if we can determine a way to manage that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Investigating We are looking into this issue at this time.
Projects
None yet
Development

No branches or pull requests

2 participants