diff --git a/Changelog.md b/Changelog.md index 838a9f70..b9fabd35 100644 --- a/Changelog.md +++ b/Changelog.md @@ -2,6 +2,9 @@ This page contains information about changes to the PowerBI Visual Tools (pbiviz). +## 5.4.1 +* Updated R-based visuals settings.ts file to work properly with the new API + ## 5.4.0 * Updated packages * New command `pbiviz lint` to run lint check from tools. It'll use eslintrc file from the root of the visual, if there is no such file, recommended one will be used instead. diff --git a/package-lock.json b/package-lock.json index ccbb7c91..90bbc490 100644 --- a/package-lock.json +++ b/package-lock.json @@ -1,12 +1,12 @@ { "name": "powerbi-visuals-tools", - "version": "5.3.0", + "version": "5.4.1", "lockfileVersion": 3, "requires": true, "packages": { "": { "name": "powerbi-visuals-tools", - "version": "5.3.0", + "version": "5.4.1", "license": "MIT", "dependencies": { "@typescript-eslint/parser": "^6.17.0", @@ -2604,9 +2604,9 @@ "integrity": "sha512-36yxDn5H7OFZQla0/jFJmbIKTdZAQHngCedGxiMmpNfEZM0sdEeT+WczLQrjK6D7o2aiyLYDnkw0R3JK0Qv1RQ==" }, "node_modules/follow-redirects": { - "version": "1.15.3", - "resolved": "https://registry.npmjs.org/follow-redirects/-/follow-redirects-1.15.3.tgz", - "integrity": "sha512-1VzOtuEM8pC9SFU1E+8KfTjZyMztRsgEfwQl44z8A25uy13jSzTj6dyK2Df52iV0vgHCfBwLhDWevLn95w5v6Q==", + "version": "1.15.5", + "resolved": "https://registry.npmjs.org/follow-redirects/-/follow-redirects-1.15.5.tgz", + "integrity": "sha512-vSFWUON1B+yAw1VN4xMfxgn5fTUiaOzAJCKBwIIgT/+7CuGy9+r+5gITvP62j3RmaD5Ph65UaERdOSRGUzZtgw==", "funding": [ { "type": "individual", diff --git a/package.json b/package.json index 9d5eb04c..0d7e7851 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "powerbi-visuals-tools", - "version": "5.4.0", + "version": "5.4.1", "description": "Command line tool for creating and publishing visuals for Power BI", "main": "./bin/pbiviz.js", "type": "module", diff --git a/templates/visuals/rhtml/src/settings.ts b/templates/visuals/rhtml/src/settings.ts index db2248e0..30511f94 100644 --- a/templates/visuals/rhtml/src/settings.ts +++ b/templates/visuals/rhtml/src/settings.ts @@ -31,14 +31,24 @@ import { formattingSettings } from "powerbi-visuals-utils-formattingmodel"; import FormattingSettingsCard = formattingSettings.SimpleCard; import FormattingSettingsSlice = formattingSettings.Slice; import FormattingSettingsModel = formattingSettings.Model; - +import TextInput = formattingSettings.TextInput; /** * RCV Script Formatting Card */ class rcvScriptCardSettings extends FormattingSettingsCard { - provider: FormattingSettingsSlice = undefined; - source: FormattingSettingsSlice = undefined; + provider: FormattingSettingsSlice = new TextInput({ + name: "provider", + displayName: "Provider", + value: undefined, + placeholder: "Provider" + }); + source: FormattingSettingsSlice = new TextInput({ + name: "source", + displayName: "Source", + value: undefined, + placeholder: "Source" + }); name: string = "rcv_script"; displayName: string = "rcv_script"; @@ -46,8 +56,7 @@ class rcvScriptCardSettings extends FormattingSettingsCard { } /** -* visual settings model class -* +* Visual settings model class */ export class VisualFormattingSettingsModel extends FormattingSettingsModel { // Create formatting settings model formatting cards diff --git a/templates/visuals/rvisual/src/settings.ts b/templates/visuals/rvisual/src/settings.ts index db2248e0..30511f94 100644 --- a/templates/visuals/rvisual/src/settings.ts +++ b/templates/visuals/rvisual/src/settings.ts @@ -31,14 +31,24 @@ import { formattingSettings } from "powerbi-visuals-utils-formattingmodel"; import FormattingSettingsCard = formattingSettings.SimpleCard; import FormattingSettingsSlice = formattingSettings.Slice; import FormattingSettingsModel = formattingSettings.Model; - +import TextInput = formattingSettings.TextInput; /** * RCV Script Formatting Card */ class rcvScriptCardSettings extends FormattingSettingsCard { - provider: FormattingSettingsSlice = undefined; - source: FormattingSettingsSlice = undefined; + provider: FormattingSettingsSlice = new TextInput({ + name: "provider", + displayName: "Provider", + value: undefined, + placeholder: "Provider" + }); + source: FormattingSettingsSlice = new TextInput({ + name: "source", + displayName: "Source", + value: undefined, + placeholder: "Source" + }); name: string = "rcv_script"; displayName: string = "rcv_script"; @@ -46,8 +56,7 @@ class rcvScriptCardSettings extends FormattingSettingsCard { } /** -* visual settings model class -* +* Visual settings model class */ export class VisualFormattingSettingsModel extends FormattingSettingsModel { // Create formatting settings model formatting cards