Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sandbox attribute to the iframe #385

Closed
wants to merge 1 commit into from

Conversation

kopecmi8
Copy link

Based on https://community.powerbi.com/t5/Service/Power-BI-Embedded-iframe-sandbox-attribute/m-p/2362079

We want to add sandbox attribute for safe embedding of your reports in our application. I tried to find another way, but the library currently doesn't allow us to pass the attribute in any way.

@Duskfen
Copy link

Duskfen commented Feb 21, 2024

@mattmazzola kindly asking, why does this not get merged

@aliabufoul aliabufoul self-assigned this Aug 29, 2024
@aliabufoul
Copy link
Contributor

I agree with adding the sandbox attribute in general.
The current changes might be risky as it can potentially block some of the capabilities for embedded reports.
For example, if allows-download is not added to the sandbox attribute, it might block the capability of exporting visual data.
We prefer to do this change internally, so we can test it against the capabilities of embed

@aliabufoul aliabufoul closed this Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants