Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added vc sln and vcxproj files #26

Closed
wants to merge 1 commit into from
Closed

Added vc sln and vcxproj files #26

wants to merge 1 commit into from

Conversation

OfekShilon
Copy link
Contributor

Currently required PlatformSDK is default (8.1), considering requiring the one bundled with latest VS (10.0.17134.0).

Included configurations for Release/Debug x MT/MD x x64/x86 .

This can save some mundane work for devs working in VS, wishing to use detours. It's time to modernize the build script a bit anyway.

…ault (8.1), considering requiring the one bundled with latest VS (10.0.17134.0)
@LonghronShen
Copy link

Maybe PR #48 also helps.
Using CMake to generate VS projects looks good, or just open the CMakeLists.txt using VS2017+ is better.

@dtarditi
Copy link
Contributor

@OfekShilon, thanks for the proposed PR. What do you think of the suggestion from @LonghronShen to use CMake instead?

@OfekShilon
Copy link
Contributor Author

Sounds like a good idea.

@dtarditi
Copy link
Contributor

Ok, closing this PR in favor of PR #48. Thanks for proposing this change and encouraging us to move things forward on the build system.

@dtarditi dtarditi closed this Jan 25, 2019
sonyps5201314 added a commit to sonyps5201314/Detours that referenced this pull request Oct 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants