fix: Optimize memory usage when parsing LgFiles #9614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sw-joelmut
changed the title
OEvgeny
reviewed
Jul 24, 2023
OEvgeny
reviewed
Jul 24, 2023
|
Looks good, left a couple of comments to address. Nice work! |
|
Hi @OEvgeny, the suggestions are applied, thanks! |
OEvgeny
approved these changes
Aug 1, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#minor
Description
This PR reduces the memory usage when parsing the LgFiles (lgParse.worker) by adding a
MapOptimizerto theLgFilesCache.This optimizer consists of, based on a capacity limit, the process will start removing LgFile parse results to free up space from memory. Additionally, it takes into account all the references and relationships between other LgFiles.
Screenshots
The following image shows loading 9 bot responses with the
MapOptimizercapacity size of 3 (for testing purposes), seeing the improvement in memory usage.