-
Notifications
You must be signed in to change notification settings - Fork 372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: [#9331] Substring function contains wrong tooltip information #9351
Conversation
Hello @OEvgeny , We reach out to you because we are having issues with Prs modifying extensions in BotFramework-Composer, and we saw that you created some successful PRs updating the same packages (# 9396). Thanks! |
@erquirogasw the |
@OEvgeny we executed the yarn build:dev command in Composer/packages/tools/built-in-functions to update the yarn files related to the changes of this PR and multiple libraries were modified in extensions (azurePublish, azurePublishNew, etc). We also tried removing the node_modules folder but more libraries were updated, compared to the ones we modified. |
@erquirogasw please ensure you pulled the latest version from main before updating the sums. |
@OEvgeny, we cloned the repository again and after running yarn install and yarn build:dev in the Composer/ folder, we noticed that several yarn-berry.lock files were modified in extensions/. We didn't introduce any changes, just built the project on main branch. |
This might be platform-related issue. Yarn has an issue with hash persistence across platforms unfortunately. |
45fd507
to
20a82fe
Compare
Hi @BruceHaley, we have the E2E tests failing in this PR and in a few others. Also, there's a component governance error, but we don't have access to the pipeline to understand the problem and fix it. Could you help us with this? |
@ceciliaavila e2e pipeline failure seem unrelated to the PR. You can run e2e tests locally for more details |
Should be good to go after related package lock hash updates |
Description
This PR fixes the tooltip description of the Substring function to reflect the current parameters.
Note: we tested the case reported in the issue:
but the exception was not thrown so we didn't update that part of the description.
Task Item
Fixes #9331
Screenshots
These images show the before and after.