-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Dev] Refactor Backend Dispatch and Kernel Wrap Related Design #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ability and maintainability
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request mainly includes changes to improve the architecture of the project, modify the CI workflow, and update the third-party notices. The most significant changes are the addition of the
LibraryGenerator
class, the modification of theBaseWrapper
class, and the changes in the import statements to reflect the new project structure.Improvements to project architecture:
bitblas/base/roller/__init__.py
,bitblas/base/roller/policy/default.py
,bitblas/base/roller/policy/tensorcore.py
,bitblas/base/utils.py
: Modified the import statements to reflect the new project structure. [1] [2] [3] [4]bitblas/builder/lib_generator/__init__.py
: Added theLibraryGenerator
class, which compiles and loads libraries, and handles the source and library paths.bitblas/builder/wrapper/__init__.py
,bitblas/builder/wrapper/base.py
: Modified theBaseWrapper
class to include thewrap
method. [1] [2]bitblas/cache/operator.py
: Updated the method signatures and the method calls to usesrcpath
andlibpath
instead ofsrc_name
andlib_name
. [1] [2] [3]bitblas/generator.py
: Removed theBitBLASGenerator
class.bitblas/ops/general_matmul/__init__.py
: Renamed frombitblas/ops/general_matmul.py
and updated the import statements to reflect the new project structure. Also modified theMatmulConfig
class to inherit fromOperatorConfig
. [1] [2] [3]CI workflow modification:
.github/workflows/ci.yml
: Modified the workflow to only run on pull requests instead of both push and pull requests.Third-party notices update:
THIRDPARTYNOTICES.txt
: Added the notice forIST-DASLab/marlin/
.Ref to dicussion #81