-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Dev] Improve General Matmul With Splitk #50
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes changes to the
bitblas
library and its associated tests. The most significant changes include enabling debug output inQuickStart.md
, modifying theforward
method inpython/bitblas/module/__init__.py
andpython/bitblas/ops/general_matmul_splitk.py
, and adjusting the testing scriptstesting/python/operators/test_general_matmul_fp8.py
andtesting/python/operators/test_general_matmul_splitk_ops.py
.Debug output:
docs/QuickStart.md
: Enabled debug output in three examples usingbitblas.set_debug_level("Debug")
. [1] [2] [3]Codebase modifications:
python/bitblas/module/__init__.py
: Modified theforward
method to include astream
variable and astream_handle
variable, which is passed to thelib.call
method.python/bitblas/ops/general_matmul_splitk.py
: Adjusted theforward
method to change the shape of theoutput
tensor, create a newsk_output
tensor, and use thetorch.sum
method to populate theoutput
tensor. [1] [2] [3]Testing script adjustments:
testing/python/operators/test_general_matmul_fp8.py
: Commented out the call tobitblas.testing.main()
and added a call totest_matmul_torch_forward_weight_dequantize
.testing/python/operators/test_general_matmul_splitk_ops.py
: Made several changes to the test methods, including adding aSplitK
parameter, replacing theget_codegen_result
method with a comparison ofoutput_bitblas
andoutput_torch
, and adding amap_torch_type
method to map input types to torch types. [1] [2] [3]