Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The 'Cancel' action next to the message 'Loading all items for global sort' doesn't take effect #7072

Closed
v-xianya opened this issue Jul 17, 2023 · 2 comments
Assignees
Labels
⚙️ tables Related to table storage 🧪 testing Found through regular testing ✅ merged A fix for this issue has been merged
Milestone

Comments

@v-xianya
Copy link
Member

Storage Explorer Version: 1.31.0-dev
Build Number: 20230717.1
Branch: main
Platform/OS: Windows 10/Linux Ubuntu 20.04/MacOS Ventura 13.4.1 (Apple M1 Pro)
Architecture: x64/arm64
How Found: From running test cases
Regression From: Not a regression

Steps to Reproduce

  1. Open Settings -> Data Explorers-> Enable the setting 'Global Sort'.
  2. Create a new table -> Add two entities.
  3. Sort the entities by one column.
  4. There is a notification message 'Loading all items for global sort (x items found)'.
  5. Click 'Cancel' next to the message.
  6. Check whether the 'Cancel' action takes effect.

Expected Experience

The 'Cancel' action takes effect.

Actual Experience

The 'Cancel' action does not take effect.
image

@v-xianya v-xianya added 🧪 testing Found through regular testing ⚙️ tables Related to table storage labels Jul 17, 2023
@MRayermannMSFT MRayermannMSFT added this to the 1.31.0 milestone Jul 17, 2023
@craxal
Copy link
Contributor

craxal commented Jul 19, 2023

@v-xianya It sounds like the reason the Cancel action doesn't work is because all the items are already loaded, so there's nothing to cancel. The real bug here is the message doesn't disappear after loading completes. In fact, a message shouldn't show up at all, because all the items are already loaded.

@craxal craxal added the ✅ merged A fix for this issue has been merged label Jul 20, 2023
@craxal craxal closed this as completed Jul 20, 2023
@v-xianya
Copy link
Member Author

Verified this issue on the main build 20230724.1. Fixed.

  1. The message will auto disappear if all items are loaded.
  2. The loading message disappears after clicking 'Cancel'.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚙️ tables Related to table storage 🧪 testing Found through regular testing ✅ merged A fix for this issue has been merged
Projects
None yet
Development

No branches or pull requests

3 participants