Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Turkish (TR) strings #2453

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add Turkish (TR) strings #2453

wants to merge 3 commits into from

Conversation

ysfchn
Copy link
Contributor

@ysfchn ysfchn commented Jul 21, 2024

This PR adds Turkish (language code is tr) strings for all packages from what I could find, except play-services-nearby (I had no time to also translate that but plan to do that later.)

  • play-services-ads-identifier
  • play-services-auth-api-phone
  • play-services-base
  • play-services-core
  • play-services-droidguard
  • play-services-fido
  • play-services-location
  • play-services-oss-licenses
  • vending-app

I've kept copyright notices as-is, and I noticed few of strings a wrapped with " (quotation) character, I assume it is written to escape ' (apostrophe), so I added backslash in front of each ' to avoid wrapping the whole string with " instead to make it consistent with other strings. I'm not sure if I have to do something else to make microG display in Turkish but after taking a look at Android documentation, I guess adding a new folder values-tr is enough.

Thanks for making microG by the way, I cannot express in words how much it has helped me.

@lucasmz-dev
Copy link
Contributor

lucasmz-dev commented Jul 23, 2024

You might wanna try and import this to Weblate
https://hosted.weblate.org/projects/microg/#languages, worth linking because I don't think it has been linked anywhere even though it is used
It causes less issues that way with merging and so, though to be fair it seems turkish does not have any files so I don't think there would be a merge conflict here, but after this is merged it should show up just fine there as well.

Well, anyhow it is nice to have since you can set up notifications for new strings and such;

@lucasmz-dev
Copy link
Contributor

lucasmz-dev commented Jul 23, 2024

https://github.com/microg/GmsCore/tree/master/play-services-core/microg-ui-tools/src/main/res

This one is significant and you may wanna do, it isn't on Weblate and you have to open a PR for it atm, so might as well take advantage

It is basically the entire portion of the Self-Check feature and a few other things

@ysfchn
Copy link
Contributor Author

ysfchn commented Jul 23, 2024

It causes less issues that way with merging and so, though to be fair it seems turkish does not have any files so I don't think there would be a merge conflict here, but after this is merged it should show up just fine there as well.

I didn't know there was a Weblate project for MicroG until I created this PR, but it seems that Weblate doesn't include a Turkish language yet, so even if I wanted to, it is not possible to contribute on Weblate for Turkish.

This one is significant and you may wanna do, it isn't on Weblate and you have to open a PR for it atm, so might as well take advantage

Huh, I somehow missed that file, thanks, will push a new commit for it soon. Edit: Done.

@lucasmz-dev
Copy link
Contributor

I didn't know there was a Weblate project for MicroG until I created this PR, but it seems that Weblate doesn't include a Turkish language yet, so even if I wanted to, it is not possible to contribute on Weblate for Turkish.

Yeah, it isn't linked anywhere yet except for commits 😵‍💫
If you wanted to add it, you just have to have an account, then add Turkish as one of the languages you can translate to, then you should be able to add that language.

Anyway, good job :P

@ysfchn
Copy link
Contributor Author

ysfchn commented Aug 8, 2024

I somehow messed up the commit history while pulling the latest commits, everything should be fine now. And I noticed missing escapes, so I fixed these problematic strings.

@ysfchn ysfchn reopened this Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants