Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

System network location provider does not report locations #2564

Open
mar-v-in opened this issue Sep 28, 2024 · 9 comments
Open

System network location provider does not report locations #2564

mar-v-in opened this issue Sep 28, 2024 · 9 comments

Comments

@mar-v-in
Copy link
Member

In v0.3.3.240913, the system network location provider would not return network locations even if bound by the system. This breaks network location in apps that only use the system network location provider and not the Google fused location provider, so this mostly affects free software apps.

@CoelacanthusHex
Copy link
Contributor

It may be better to release 0.3.3.1 to include this fix since it breaks most free software.

@sconim
Copy link

sconim commented Sep 28, 2024

I have updated before the note about the bug was released and unfortunately reverting back to 0.3.2.240913 doesn't help. Upon reinstalling the previous version, the network location service is still broken, My Location (FOSS from GitHub) reports that Network Location service has been stopped and microG keeps crashing.

Releasing a fix as soon as possible would be highly appreciated. The votes above clearly suggest that I'm not the only one. Thanks for your excellent work!

@ale5000-git
Copy link
Member

@mar-v-in
Isn't possible to create a branch starting at the commit 52a08ba (the commit of the 0.3.3 release) and then merge only the location fix in that branch?
So you can create a tag from that branch and you can avoid the commits added after the release.

@mar-v-in
Copy link
Member Author

The fix in 2149212 is incomplete, it can result in network location requests staying active infinitely (which is not much better than not getting started at all), so further fixing is needed. I'm mostly done with that and I can backport the relevant parts to 0.3.3 to create a 0.3.3.1 version afterwards - and/or provide a nightly based on then-current master.

@mar-v-in mar-v-in reopened this Sep 30, 2024
@ale5000-git
Copy link
Member

@mar-v-in
Does the latest commit fix "network location requests staying active infinitely"?

@sconim
Copy link

sconim commented Oct 6, 2024

@ale5000-git Which latest commit?

@sconim
Copy link

sconim commented Oct 6, 2024

@mar-v-in Any timeline as far as releasing either the 0.3.3.1, or 0.3.4?

@ale5000-git
Copy link
Member

@sconim
The commit 511afe8, the commit date is last week but it was pushed today.

@lucasmz-dev
Copy link
Contributor

If it would be possible/not hard to do a last pull from Weblate right before next release, even if it's a bugfix release, I'd help our work tremendously, I have no easy way of checking easily how things look in-app. Building so far hasn't worked for me and I have no idea how to change the package names. I ended up having to use things like Lucky Patcher on a new release (CalyxOS hasn't launched 0.3.3 because of this bug) which really wasn't ideal. Updates to microG are months apart, so it's complicated to get an overall pic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants