Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: Vendor'ed test suite as git submodule? #97

Open
jgarber623 opened this issue Aug 20, 2018 · 2 comments
Open

Question: Vendor'ed test suite as git submodule? #97

jgarber623 opened this issue Aug 20, 2018 · 2 comments

Comments

@jgarber623
Copy link
Member

Now that this gem's test suite is back in sync with microformats/tests, would it be possible to directly include the code in that repo into this project via a git submodule or some mechanism other than copy/paste?

Git submodules aren't without their overhead, but we could mitigate potential problems by updating some documentation with details on how to handle initial project check out, updating the test suite version, etc.

@dissolve
Copy link
Collaborator

I've been debating this on https://github.com/dissolve/mf2-tester as well. One option is to use composer (its in the exact right location for it) but I don't really want to force ruby devs to install composer. Its possible to just use composer and then just not put /vendor in .gitignore

@jgarber623
Copy link
Member Author

I had the same thought about NPM. It's built into the test suite, but is Yet Another Package Manager™ akin to your PHP/Composer example.

Git submodule is the lowest common denominator but it's far from perfect… 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants